Re: [PATCH 06/27] emacs: fix old bug in notmuch-mua-mail

Subject: Re: [PATCH 06/27] emacs: fix old bug in notmuch-mua-mail

Date: Sun, 15 Nov 2020 20:39:30 +0000

To: Jonas Bernoulli, notmuch@notmuchmail.org

Cc:

From: David Edmondson


On Sunday, 2020-11-08 at 20:02:50 +01, Jonas Bernoulli wrote:

> This fixes a regression introduced in [1: 7e20d264].  If the argument
> RETURN-ACTION was non-nil then we should pass along the value of that
> argument.  Instead we passed along the constant symbol `return-action'.
>
> 1: 7e20d26480553f57d53bd9ec28cae163c1ac91e3
>    emacs: Fix mail composition under Emacs 23

Reviewed-by: David Edmondson <dme@dme.org>

> ---
>  emacs/notmuch-mua.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index 616b625c..1204fb6a 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -402,7 +402,7 @@ (defun notmuch-mua-mail (&optional to subject other-headers continue
>      ;; argument. Pass it only if it is supplied by the caller. This
>      ;; will never be the case when we're called by `compose-mail' in
>      ;; Emacs 23.
> -    (when return-action (nconc args '(return-action)))
> +    (when return-action (nconc args (list return-action)))
>      (apply 'message-setup-1 headers args))
>    (notmuch-fcc-header-setup)
>    (message-sort-headers)
> -- 
> 2.29.1
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org

dme.
-- 
This is not how I woke up, but it's how I look now.
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: