Re: [PATCH 00/23] Another set up Emacs cleanup

Subject: Re: [PATCH 00/23] Another set up Emacs cleanup

Date: Mon, 16 Nov 2020 22:47:48 +0000

To: Jonas Bernoulli, notmuch@notmuchmail.org

Cc:

On Monday, 2020-11-16 at 22:28:20 +01, Jonas Bernoulli wrote:

> This remove the first four commits, which have already been
> applied to master.  It also makes requested minor changes
> to the three marked commits.

For the set...

Reviewed-by: David Edmondson <dme@dme.org>

> Jonas Bernoulli (23):
>   emacs: remove redundant notmuch-hello-trim
>   emacs: fix old bug in notmuch-mua-mail
>   emacs: remove kludge for Emacs 23 from notmuch-mua-mail
>   emacs: more cleanup since dropping support for Emacs 24
>   emacs: sanitize function that displays version
>   emacs: define notmuch-hello-url as a constant
>   emacs: shorten/replace first sentence of a few doc-strings
>   emacs: place only first sentence on first doc-string line
> * emacs: place complete first sentence on first doc-string line
>   emacs: always use elisp quoting style in doc-strings
> * emacs: misc doc-string improvements
>   emacs: remove deprecated notmuch-folder command
>   emacs: remove unnecessary notmuch-remove-if-not
>   emacs: remove unused notmuch-address-locate-command
>   emacs: remove unnecessary notmuch-tree-button-activate
>   emacs: inline notmuch-documentation-first-line
>   emacs: inline notmuch-split-content-type
>   emacs: use defvar-local
>   emacs: use setq-local
>   emacs: use setq instead set
>   emacs: do not quote self-quoting t
>   emacs: avoid binding unnamed commands in keymaps
> * emacs: various cosmetic improvements
>
>  emacs/coolj.el               |   4 +-
>  emacs/notmuch-address.el     |  58 ++++--------
>  emacs/notmuch-company.el     |   7 +-
>  emacs/notmuch-compat.el      |   9 +-
>  emacs/notmuch-crypto.el      |   7 +-
>  emacs/notmuch-draft.el       |  17 ++--
>  emacs/notmuch-hello.el       | 123 +++++++++----------------
>  emacs/notmuch-jump.el        |   5 --
>  emacs/notmuch-lib.el         | 108 +++++++++-------------
>  emacs/notmuch-maildir-fcc.el |  12 +--
>  emacs/notmuch-mua.el         |  64 ++++++-------
>  emacs/notmuch-parser.el      |   5 +-
>  emacs/notmuch-show.el        |  56 ++++++------
>  emacs/notmuch-tag.el         |  24 ++---
>  emacs/notmuch-tree.el        | 170 ++++++++++++++++++-----------------
>  emacs/notmuch.el             | 108 +++++++++++-----------
>  16 files changed, 331 insertions(+), 446 deletions(-)
>
> -- 
> 2.29.1
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org

dme.
-- 
Come down, come talk to me.
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Previous message (by thread): Re: [PATCH 26/27] emacs: avoid binding unnamed commands in keymaps

Thread:

Jonas Bernoulli—[PATCH 00/27] Another set up Emacs cleanup [inbox, unread]
- Jonas Bernoulli—[PATCH 01/27] emacs: silence byte-compiler [inbox, notmuch::patch, notmuch::pushed, unread]
  - William Casarin—Re: [PATCH 01/27] emacs: silence byte-compiler [inbox, unread]
    - Jonas Bernoulli—Re: [PATCH 01/27] emacs: silence byte-compiler [inbox, unread]
      - William Casarin—Re: [PATCH 01/27] emacs: silence byte-compiler [inbox, unread]
- Jonas Bernoulli—[PATCH 02/27] emacs: define notmuch-message-mode-map explicitly [inbox, notmuch::patch, notmuch::pushed, unread]
  - William Casarin—Re: [PATCH 02/27] emacs: define notmuch-message-mode-map explicitly [inbox, unread]
- Jonas Bernoulli—[PATCH 03/27] emacs: add doc-string to notmuch-tree-mode-map [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
- Jonas Bernoulli—[PATCH 04/27] emacs: don't fset keymaps [inbox, notmuch::patch, notmuch::pushed, unread]
  - William Casarin—Re: [PATCH 04/27] emacs: don't fset keymaps [inbox, unread]
    - David Bremner—Re: [PATCH 04/27] emacs: don't fset keymaps [inbox, unread]
- Jonas Bernoulli—[PATCH 05/27] emacs: remove redundant notmuch-hello-trim [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 06/27] emacs: fix old bug in notmuch-mua-mail [inbox, notmuch::obsolete, notmuch::patch, notmuch::pushed, unread]
  - David Edmondson—Re: [PATCH 06/27] emacs: fix old bug in notmuch-mua-mail [inbox, unread]
- Jonas Bernoulli—[PATCH 07/27] emacs: remove kludge for Emacs 23 from notmuch-mua-mail [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 08/27] emacs: more cleanup since dropping support for Emacs 24 [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 09/27] emacs: sanitize function that displays version [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 10/27] emacs: define notmuch-hello-url as a constant [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 11/27] emacs: shorten/replace first sentence of a few doc-strings [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 12/27] emacs: place only first sentence on first doc-string line [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 13/27] emacs: place complete first sentence on first doc-string line [inbox, notmuch::obsolete, notmuch::patch, unread]
  - David Edmondson—Re: [PATCH 13/27] emacs: place complete first sentence on first doc-string line [inbox, unread]
    - Jonas Bernoulli—Re: [PATCH 13/27] emacs: place complete first sentence on first doc-string line [inbox, unread]
- Jonas Bernoulli—[PATCH 14/27] emacs: always use elisp quoting style in doc-strings [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 15/27] emacs: misc doc-string improvements [inbox, notmuch::obsolete, notmuch::patch, unread]
  - David Edmondson—Re: [PATCH 15/27] emacs: misc doc-string improvements [inbox, unread]
- Jonas Bernoulli—[PATCH 16/27] emacs: remove deprecated notmuch-folder command [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 17/27] emacs: remove unnecessary notmuch-remove-if-not [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 18/27] emacs: remove unused notmuch-address-locate-command [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 19/27] emacs: remove unnecessary notmuch-tree-button-activate [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 20/27] emacs: inline notmuch-documentation-first-line [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 21/27] emacs: inline notmuch-split-content-type [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 22/27] emacs: use defvar-local [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 23/27] emacs: use setq-local [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 24/27] emacs: use setq instead set [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 25/27] emacs: do not quote self-quoting t [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 26/27] emacs: avoid binding unnamed commands in keymaps [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Ryan Tate—Re: [PATCH 26/27] emacs: avoid binding unnamed commands in keymaps [inbox, unread]
    - Michael J Gruber—Re: [PATCH 26/27] emacs: avoid binding unnamed commands in keymaps [inbox, unread]
      - Ryan Tate—Re: [PATCH 26/27] emacs: avoid binding unnamed commands in keymaps [inbox, unread]
    - David Bremner—Re: [PATCH 26/27] emacs: avoid binding unnamed commands in keymaps [inbox, unread]
- Jonas Bernoulli—[PATCH 27/27] emacs: various cosmetic improvements [inbox, notmuch::obsolete, notmuch::patch, unread]
  - David Edmondson—Re: [PATCH 27/27] emacs: various cosmetic improvements [inbox, unread]
    - Jonas Bernoulli—Re: [PATCH 27/27] emacs: various cosmetic improvements [inbox, unread]
- Jonas Bernoulli—[PATCH 00/23] Another set up Emacs cleanup [inbox, unread]
  - Jonas Bernoulli—[PATCH v2 01/23] emacs: remove redundant notmuch-hello-trim [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 02/23] emacs: fix old bug in notmuch-mua-mail [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 03/23] emacs: remove kludge for Emacs 23 from notmuch-mua-mail [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 04/23] emacs: more cleanup since dropping support for Emacs 24 [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 05/23] emacs: sanitize function that displays version [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 06/23] emacs: define notmuch-hello-url as a constant [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 07/23] emacs: shorten/replace first sentence of a few doc-strings [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 08/23] emacs: place only first sentence on first doc-string line [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 09/23] emacs: place complete first sentence on first doc-string line [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 10/23] emacs: always use elisp quoting style in doc-strings [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 11/23] emacs: misc doc-string improvements [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 12/23] emacs: remove deprecated notmuch-folder command [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 13/23] emacs: remove unnecessary notmuch-remove-if-not [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 14/23] emacs: remove unused notmuch-address-locate-command [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 15/23] emacs: remove unnecessary notmuch-tree-button-activate [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 16/23] emacs: inline notmuch-documentation-first-line [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 17/23] emacs: inline notmuch-split-content-type [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 18/23] emacs: use defvar-local [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 19/23] emacs: use setq-local [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 20/23] emacs: use setq instead set [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 21/23] emacs: do not quote self-quoting t [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 22/23] emacs: avoid binding unnamed commands in keymaps [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v2 23/23] emacs: various cosmetic improvements [inbox, notmuch::obsolete, notmuch::patch, unread]
    - David Bremner—Re: [PATCH v2 23/23] emacs: various cosmetic improvements [inbox, unread]
      - Jonas Bernoulli—Re: [PATCH v2 23/23] emacs: various cosmetic improvements [inbox, unread]
        David Bremner—Re: [PATCH v2 23/23] emacs: various cosmetic improvements [inbox, unread]
  - David Edmondson—Re: [PATCH 00/23] Another set up Emacs cleanup [inbox, unread]