Re: [PATCH v4 0/4] First step of 'show' rewrite

Subject: Re: [PATCH v4 0/4] First step of 'show' rewrite

Date: Fri, 23 Dec 2011 23:55:28 -0800

To: Austin Clements, notmuch@notmuchmail.org

Cc:

On Fri, 23 Dec 2011 22:45:44 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> This addresses Dmitry's and Jameson's review comments from
>   id:"87k46572f7.fsf@gmail.com"
>   id:"87liqk5dly.fsf@servo.finestructure.net"
>   id:"87hb187iu6.fsf@gmail.com"
> and rebases to current master.
> 
> I'd like a quick eye over this to make sure I didn't screw anything up
> in the latest version, but otherwise I think it's ready to go in.

Hey, Austin.  Thanks so much for the rework.  I have one very minor
comment, but other than that it all looks really good to me (as usual).
All tests pass as expected when applied to master.  I'm looking forward
to what else you've got in store on top of this!

jamie.

part-000.sig (application/pgp-signature)

Previous message (by thread): Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal.

Thread:

Austin Clements—[PATCH 0/4] First step of 'show' rewrite [inbox, unread]
- Austin Clements—[PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body. [inbox, notmuch::obsolete, notmuch::patch, unread]
- Austin Clements—[PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jani Nikula—Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::review, unread]
    - Austin Clements—Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, unread]
- Austin Clements—[PATCH 3/4] Utility function to seek in MIME trees in depth-first order. [inbox, notmuch::obsolete, notmuch::patch, unread]
- Austin Clements—[PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface. [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jani Nikula—Re: [PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface. [inbox, unread]
- Jameson Graef Rollins—Re: [PATCH 0/4] First step of 'show' rewrite [inbox, signed, unread]
- Austin Clements—[PATCH v2 0/4] First step of 'show' rewrite [inbox, unread]
  - Austin Clements—[PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body. [inbox, notmuch::obsolete, notmuch::patch, unread]
    - Dmitry Kurochkin—Re: [PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body. [inbox, unread]
      - Austin Clements—Re: [PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body. [inbox, unread]
        Dmitry Kurochkin—Re: [PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body. [inbox, notmuch::review, unread]
  - Austin Clements—[PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Austin Clements—[PATCH 3/4] Utility function to seek in MIME trees in depth-first order. [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Austin Clements—[PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface. [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Austin Clements—Re: [PATCH v2 0/4] First step of 'show' rewrite [inbox, unread]
    - Dmitry Kurochkin—Re: [PATCH v2 0/4] First step of 'show' rewrite [inbox, unread]
      - Jameson Graef Rollins—Re: [PATCH v2 0/4] First step of 'show' rewrite [inbox, signed, unread]
  - Austin Clements—[PATCH v3 0/4] First step of 'show' rewrite [inbox, unread]
    - Austin Clements—[PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body. [inbox, notmuch::obsolete, notmuch::patch, unread]
    - Austin Clements—[PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::obsolete, notmuch::patch, unread]
      - Dmitry Kurochkin—Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::review, unread]
        Jameson Graef Rollins—Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::review, signed, unread]
        Austin Clements—Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, unread]
        Austin Clements—Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, unread]
        Daniel Kahn Gillmor—Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, signed, unread]
        Austin Clements—Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, unread]
      - Jameson Graef Rollins—Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::review, signed, unread]
    - Austin Clements—[PATCH 3/4] Utility function to seek in MIME trees in depth-first order. [inbox, notmuch::obsolete, notmuch::patch, unread]
      - Dmitry Kurochkin—Re: [PATCH 3/4] Utility function to seek in MIME trees in depth-first order. [inbox, notmuch::review, unread]
        Austin Clements—Re: [PATCH 3/4] Utility function to seek in MIME trees in depth-first order. [inbox, unread]
        Dmitry Kurochkin—Re: [PATCH 3/4] Utility function to seek in MIME trees in depth-first order. [inbox, unread]
    - Austin Clements—[PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface. [inbox, notmuch::obsolete, notmuch::patch, unread]
      - Dmitry Kurochkin—Re: [PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface. [inbox, notmuch::review, unread]
        Austin Clements—Re: [PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface. [inbox, unread]
    - Jameson Graef Rollins—Re: [PATCH v3 0/4] First step of 'show' rewrite [inbox, signed, unread]
    - Dmitry Kurochkin—Re: [PATCH v3 0/4] First step of 'show' rewrite [inbox, unread]
      - David Bremner—Re: [PATCH v3 0/4] First step of 'show' rewrite [inbox, unread]
    - Austin Clements—[PATCH v4 0/4] First step of 'show' rewrite [inbox, unread]
      - Austin Clements—[PATCH v4 1/4] show: Pass notmuch_message_t instead of path to show_message_body. [inbox, notmuch::obsolete, notmuch::patch, unread]
      - Austin Clements—[PATCH v4 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::obsolete, notmuch::patch, unread]
        Jameson Graef Rollins—Re: [PATCH v4 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::review, signed, unread]
        Dmitry Kurochkin—Re: [PATCH v4 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::review, unread]
        Austin Clements—Re: [PATCH v4 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, unread]
      - Austin Clements—[PATCH v4 3/4] Utility function to seek in MIME trees in depth-first order. [inbox, notmuch::obsolete, notmuch::patch, unread]
      - Austin Clements—[PATCH v4 4/4] show: Rewrite show_message_body to use the MIME tree interface. [inbox, notmuch::obsolete, notmuch::patch, unread]
      - Dmitry Kurochkin—Re: [PATCH v4 0/4] First step of 'show' rewrite [inbox, unread]
      - Jameson Graef Rollins—Re: [PATCH v4 0/4] First step of 'show' rewrite [inbox, signed, unread]
      - Austin Clements—[PATCH v5 0/4] First step of 'show' rewrite [inbox, unread]
        Austin Clements—[PATCH v5 1/4] show: Pass notmuch_message_t instead of path to show_message_body. [inbox, notmuch::patch, notmuch::pushed, unread]
        Austin Clements—[PATCH v5 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::patch, notmuch::pushed, unread]
        Austin Clements—[PATCH v5 3/4] Utility function to seek in MIME trees in depth-first order. [inbox, notmuch::patch, notmuch::pushed, unread]
        Austin Clements—[PATCH v5 4/4] show: Rewrite show_message_body to use the MIME tree interface. [inbox, notmuch::patch, notmuch::pushed, unread]
        Dmitry Kurochkin—Re: [PATCH v5 0/4] First step of 'show' rewrite [inbox, notmuch::review, unread]
        David Bremner—Re: [PATCH v5 0/4] First step of 'show' rewrite [inbox, unread]