Re: [PATCH v3 0/4] First step of 'show' rewrite

Subject: Re: [PATCH v3 0/4] First step of 'show' rewrite

Date: Sun, 11 Dec 2011 14:41:50 +0400

To: Austin Clements, notmuch@notmuchmail.org

Cc:

From: Dmitry Kurochkin

Austin, good job! :) Thanks for this work.  (and continue, please :))

Most comments in my review are minor and/or concern the old code
(i.e. the new code does not make it worse).  Please feel free to ignore
them.

I vote for pushing this series as soon as Austin finds it appropriate.
If Austin makes a new version of this patch series with some of my
comments fixed, it gets my auto-approve without another round of review :)

Regards,
  Dmitry

• Previous message (by thread): Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal.

Thread:

• Austin Clements—[PATCH 0/4] First step of 'show' rewrite [inbox, unread]
  • Austin Clements—[PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Austin Clements—[PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jani Nikula—Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::review, unread]
      • Austin Clements—Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, unread]
  • Austin Clements—[PATCH 3/4] Utility function to seek in MIME trees in depth-first order. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Austin Clements—[PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jani Nikula—Re: [PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface. [inbox, unread]
  • Jameson Graef Rollins—Re: [PATCH 0/4] First step of 'show' rewrite [inbox, signed, unread]
  • Austin Clements—[PATCH v2 0/4] First step of 'show' rewrite [inbox, unread]
    • Austin Clements—[PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body. [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Dmitry Kurochkin—Re: [PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body. [inbox, unread]
        • Austin Clements—Re: [PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body. [inbox, unread]
          • Dmitry Kurochkin—Re: [PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body. [inbox, notmuch::review, unread]
    • Austin Clements—[PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Austin Clements—[PATCH 3/4] Utility function to seek in MIME trees in depth-first order. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Austin Clements—[PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Austin Clements—Re: [PATCH v2 0/4] First step of 'show' rewrite [inbox, unread]
      • Dmitry Kurochkin—Re: [PATCH v2 0/4] First step of 'show' rewrite [inbox, unread]
        • Jameson Graef Rollins—Re: [PATCH v2 0/4] First step of 'show' rewrite [inbox, signed, unread]
    • Austin Clements—[PATCH v3 0/4] First step of 'show' rewrite [inbox, unread]
      • Austin Clements—[PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body. [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Austin Clements—[PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Dmitry Kurochkin—Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::review, unread]
          • Jameson Graef Rollins—Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::review, signed, unread]
            • Austin Clements—Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, unread]
          • Austin Clements—Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, unread]
            • Daniel Kahn Gillmor—Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, signed, unread]
              • Austin Clements—Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, unread]
        • Jameson Graef Rollins—Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::review, signed, unread]
      • Austin Clements—[PATCH 3/4] Utility function to seek in MIME trees in depth-first order. [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Dmitry Kurochkin—Re: [PATCH 3/4] Utility function to seek in MIME trees in depth-first order. [inbox, notmuch::review, unread]
          • Austin Clements—Re: [PATCH 3/4] Utility function to seek in MIME trees in depth-first order. [inbox, unread]
            • Dmitry Kurochkin—Re: [PATCH 3/4] Utility function to seek in MIME trees in depth-first order. [inbox, unread]
      • Austin Clements—[PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface. [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Dmitry Kurochkin—Re: [PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface. [inbox, notmuch::review, unread]
          • Austin Clements—Re: [PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface. [inbox, unread]
      • Jameson Graef Rollins—Re: [PATCH v3 0/4] First step of 'show' rewrite [inbox, signed, unread]
      • Dmitry Kurochkin—Re: [PATCH v3 0/4] First step of 'show' rewrite [inbox, unread]
        • David Bremner—Re: [PATCH v3 0/4] First step of 'show' rewrite [inbox, unread]
      • Austin Clements—[PATCH v4 0/4] First step of 'show' rewrite [inbox, unread]
        • Austin Clements—[PATCH v4 1/4] show: Pass notmuch_message_t instead of path to show_message_body. [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Austin Clements—[PATCH v4 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::obsolete, notmuch::patch, unread]
          • Jameson Graef Rollins—Re: [PATCH v4 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::review, signed, unread]
            • Dmitry Kurochkin—Re: [PATCH v4 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::review, unread]
            • Austin Clements—Re: [PATCH v4 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, unread]
        • Austin Clements—[PATCH v4 3/4] Utility function to seek in MIME trees in depth-first order. [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Austin Clements—[PATCH v4 4/4] show: Rewrite show_message_body to use the MIME tree interface. [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Dmitry Kurochkin—Re: [PATCH v4 0/4] First step of 'show' rewrite [inbox, unread]
        • Jameson Graef Rollins—Re: [PATCH v4 0/4] First step of 'show' rewrite [inbox, signed, unread]
        • Austin Clements—[PATCH v5 0/4] First step of 'show' rewrite [inbox, unread]
          • Austin Clements—[PATCH v5 1/4] show: Pass notmuch_message_t instead of path to show_message_body. [inbox, notmuch::patch, notmuch::pushed, unread]
          • Austin Clements—[PATCH v5 2/4] Introduce a generic tree-like abstraction for MIME traversal. [inbox, notmuch::patch, notmuch::pushed, unread]
          • Austin Clements—[PATCH v5 3/4] Utility function to seek in MIME trees in depth-first order. [inbox, notmuch::patch, notmuch::pushed, unread]
          • Austin Clements—[PATCH v5 4/4] show: Rewrite show_message_body to use the MIME tree interface. [inbox, notmuch::patch, notmuch::pushed, unread]
          • Dmitry Kurochkin—Re: [PATCH v5 0/4] First step of 'show' rewrite [inbox, notmuch::review, unread]
          • David Bremner—Re: [PATCH v5 0/4] First step of 'show' rewrite [inbox, unread]