Re: [PATCH 8/9] bindings/python: strip ~ from python version

Subject: Re: [PATCH 8/9] bindings/python: strip ~ from python version

Date: Tue, 18 Feb 2025 16:44:19 +0200

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila

On Sat, Feb 15 2025, David Bremner wrote:

> This is slightly annoying, but the pre-release versions are mainly for
> testing anyway, so the version mismatch is tolerable.
> ---
>  bindings/python-cffi/setup.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bindings/python-cffi/setup.py b/bindings/python-cffi/setup.py
> index 55fb2d24..e25a007c 100644
> --- a/bindings/python-cffi/setup.py
> +++ b/bindings/python-cffi/setup.py
> @@ -2,7 +2,7 @@ import setuptools
>  from _notmuch_config import *
>  
>  with open(NOTMUCH_VERSION_FILE) as fp:
> -    VERSION = fp.read().strip()

So far so good, just that style nitpick where I must, space before '' below..

> +    VERSION = fp.read().strip().replace('~','')
>  
>  setuptools.setup(
>      name='notmuch2',
> -- 
> 2.47.2
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: