Am So., 16. Feb. 2025 um 12:39 Uhr schrieb David Bremner <david@tethera.net>:
>
> David Bremner <david@tethera.net> writes:
>
> > It took a little more work than I anticipated, because the old python
> > bindings were used a few places in the test suite.
>
> For those with limited time (i.e. everyone),
>
> - patches 1 and 2 are trivial
> - patch 3 could use review by a C programmer
> - patch 4 is mostly trivial (and python)
> - patch 5 is a doc fix for the bindings, not strictly needed for this
>   series
> - patch 6 is just a file rename, but also the thing likely to break
>   e.g. external packaging
> - patch 7 removes some build system bits mainly used by the release
>   process (i.e. by me)
> - patch 8 automates a suggestion of Xiyue Deng. The commit message could
>   maybe be improved. It will end up with python reporting a different
>   version for the pre-releases.
> - patch 9 is here just to test patch 8. Again suggestions for improving
>   the commit message are welcome.

As is, the relation of 8+9 with the legacy move is unclear to me - I'd
suggest making this clearer, but I don't grok it muself.

As for the move in 6: per the commit message, legacy bindings are not
tested any more. Are they still being built? Are they supposed to be
built on demand?

Also, `afew`, the mail filter and mover, still uses the legacy
bindings. There is partial work for a move to notmuch2, and if I
remember correctly, it was held back both by upstreaming wanting to
support both bindings and by the issues with the thread iterator which
were discussed recently here. So, personally, I'll rather focus on
making my setup future proof (porting afew) and deferring notmuch
updates in Fedora (where I'm the package maintainer) rather than work
on this series. Sorry ;-)

Michael
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org