Re: Move legacy python bindings to contrib

Subject: Re: Move legacy python bindings to contrib

Date: Tue, 18 Feb 2025 21:30:36 +0100

To: David Bremner

Cc: notmuch@notmuchmail.org, Xiyue Deng

From: Michael J Gruber


Am So., 16. Feb. 2025 um 15:00 Uhr schrieb David Bremner <david@tethera.net>:
>
> Michael J Gruber <michaeljgruber+grubix+git@gmail.com> writes:
>
> >
> > As is, the relation of 8+9 with the legacy move is unclear to me - I'd
> > suggest making this clearer, but I don't grok it muself.
>
> OK, thanks. I think I know how to improve at least 8.

I guess I understand now that this is about PEP compliant version
numbers - setuptools or the like are getting more and more picky. The
relation to the legacy move is unclear to me, but that's not
important.

> >
> > As for the move in 6: per the commit message, legacy bindings are not
> > tested any more. Are they still being built? Are they supposed to be
> > built on demand?
>
> They are in contrib, so basically made available for people that want
> them, without digging through version control.
>
> > Also, `afew`, the mail filter and mover, still uses the legacy
> > bindings. There is partial work for a move to notmuch2, and if I
> > remember correctly, it was held back both by upstreaming wanting to
> > support both bindings and by the issues with the thread iterator which
> > were discussed recently here. So, personally, I'll rather focus on
> > making my setup future proof (porting afew) and deferring notmuch
> > updates in Fedora (where I'm the package maintainer) rather than work
> > on this series. Sorry ;-)
>
> I'm sorry to hear that afew isn't ported yet. The bindings have been
> deprecated for almost 5 years, and it's hitting a point where additional
> work is needed to keep them building. I admit this work is minor, but it
> seemed like a good time to finally pull off the bandage. Whatever issues
> the new bindings might have, the old ones have segfaulting bugs that
> seem impossible to fix.

As promised, I looked at afew first and ported it to the new bindings :)
Afew users can pick that up in the PR on Github. (I've been using the
port for a few days.)

Also, I tried building the Fedora package with this series, and this
works including tests, too. (I have not used those test packages
myself yet.)

I pre-announced the removal of legacy bindings on the Fedora devel
list, and I'll let you know in case something important comes up.

Cheers
Michael
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: