[PATCH 7/9] build: remove handling for legacy python bindings version

Subject: [PATCH 7/9] build: remove handling for legacy python bindings version

Date: Sat, 15 Feb 2025 16:05:53 -0400

To: notmuch@notmuchmail.org

Cc:

From: David Bremner


The legacy python bindings are no longer built.
---
 Makefile.global         |  2 --
 Makefile.local          |  4 +---
 devel/release-checks.sh | 14 +-------------
 3 files changed, 2 insertions(+), 18 deletions(-)

diff --git a/Makefile.global b/Makefile.global
index 7a7a3c6d..258c379c 100644
--- a/Makefile.global
+++ b/Makefile.global
@@ -47,8 +47,6 @@ DEB_TAR_FILE=$(PACKAGE)_$(VERSION).orig.tar.xz
 SHA256_FILE=$(TAR_FILE).sha256.asc
 DETACHED_SIG_FILE=$(TAR_FILE).asc
 
-PV_FILE=bindings/python/notmuch/version.py
-
 # Smash together user's values with our extra values
 FINAL_CFLAGS = -DNOTMUCH_VERSION=$(VERSION) $(WARN_CFLAGS) $(extra_cflags) $(CPPFLAGS) $(CONFIGURE_CFLAGS) $(CFLAGS)
 FINAL_CXXFLAGS = $(WARN_CXXFLAGS) $(extra_cflags) $(extra_cxxflags) $(CPPFLAGS) $(CONFIGURE_CXXFLAGS) $(CXXFLAGS)
diff --git a/Makefile.local b/Makefile.local
index 7699c208..2cc9bd29 100644
--- a/Makefile.local
+++ b/Makefile.local
@@ -60,9 +60,7 @@ dist: $(TAR_FILE)
 .PHONY: update-versions
 
 update-versions:
-	sed -i -e "s/^__VERSION__[[:blank:]]*=.*$$/__VERSION__ = \'${VERSION}\'/" \
-	    -e "s/^SOVERSION[[:blank:]]*=.*$$/SOVERSION = \'${LIBNOTMUCH_VERSION_MAJOR}\'/" \
-	    ${PV_FILE}
+	@echo nothing to do
 
 # We invoke make recursively only to force ordering of our phony
 # targets in the case of parallel invocation of make (-j).
diff --git a/devel/release-checks.sh b/devel/release-checks.sh
index c0accf78..4f81722b 100755
--- a/devel/release-checks.sh
+++ b/devel/release-checks.sh
@@ -18,8 +18,6 @@ readonly DEFAULT_IFS="$IFS" # Note: In this particular case quotes are needed.
 # Avoid locale-specific differences in output of executed commands
 LANG=C LC_ALL=C; export LANG LC_ALL
 
-readonly PV_FILE='bindings/python/notmuch/version.py'
-
 # Using array here turned out to be unnecessarily complicated
 emsgs=''
 emsg_count=0
@@ -29,7 +27,7 @@ append_emsg ()
 	emsgs="${emsgs:+$emsgs\n}  $1"
 }
 
-for f in ./version.txt debian/changelog NEWS "$PV_FILE"
+for f in ./version.txt debian/changelog NEWS
 do
 	if   [ ! -f "$f" ]; then append_emsg "File '$f' is missing"
 	elif [ ! -r "$f" ]; then append_emsg "File '$f' is unreadable"
@@ -108,16 +106,6 @@ else
 	append_emsg "Version '$deb_version' is not '($VERSION-1)' in debian/changelog"
 fi
 
-printf %s "Checking that python bindings version is $VERSION... "
-py_version=`python3 -c "with open('$PV_FILE') as vf: exec(vf.read()); print(__VERSION__)"`
-if [ "$py_version" = "$VERSION" ]
-then
-	echo Yes.
-else
-	echo No.
-	append_emsg "Version '$py_version' is not '$VERSION' in $PV_FILE"
-fi
-
 printf %s "Checking that NEWS header is tidy... "
 if [ "`exec sed 's/./=/g; 1q' NEWS`" = "`exec sed '1d; 2q' NEWS`" ]
 then
-- 
2.47.2

_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: