On Wed, Apr 16 2014, Peter Wang <novalazy@gmail.com> wrote: > Follow up to id:1374365254-13227-1-git-send-email-novalazy@gmail.com > The main changes are to take into account failures during > tagging and flushing of the database. > > I took Jani's patch id:1390152046-6509-1-git-send-email-jani@nikula.org > without modification. > > The soname bump is included in case it is required. I guess it is -- then changing in that file is not enough, lib/notmuch.h needs to have the same change. But, would a MINOR value update work -- anyone who needs only 3.1.0 could also work with 3.2.0... If MINOR update were sufficient then we would not need to add api changes that supports logging (etc.) to this conversation... ... but anyone interested these changes should also take a look of the actual changes... :D Tomi > The python/go/ruby changes are untested. > > > Jani Nikula (1): > lib: add return status to database close and destroy > > Peter Wang (9): > lib: bump soname > python: handle return status of database close and destroy > go: add return status to database close method > ruby: handle return status of database close > cli: refactor insert > cli: indicate insert failure mode in exit status > cli: add insert --must-index option > test: test insert --must-index > man: update insert documentation > > bindings/go/src/notmuch/notmuch.go | 4 +- > bindings/python/notmuch/database.py | 12 ++-- > bindings/ruby/database.c | 4 +- > doc/man1/notmuch-insert.rst | 24 +++++-- > lib/Makefile.local | 2 +- > lib/database.cc | 30 ++++++-- > lib/notmuch.h | 15 +++- > notmuch-insert.c | 134 +++++++++++++++++++++--------------- > test/T070-insert.sh | 32 +++++++-- > 9 files changed, 176 insertions(+), 81 deletions(-) > > -- > 1.8.4 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch