Re: [PATCH v2 06/10] cli: refactor insert

Subject: Re: [PATCH v2 06/10] cli: refactor insert

Date: Tue, 16 Sep 2014 21:32:16 +0200

To: Peter Wang

Cc: notmuch@notmuchmail.org

From: David Bremner


Peter Wang <novalazy@gmail.com> writes:

> On Sat, 05 Jul 2014 10:18:05 -0300, David Bremner <david@tethera.net> wrote:
>> Peter Wang <novalazy@gmail.com> writes:
>> 
>> > -    cleanup_path = tmppath;
>> > -
>> > -    if (! copy_stdin (fdin, fdout))
>> > -	goto FAIL;
>> > +    if (! copy_stdin (fdin, fdout)) {
>> > +	close (fdout);
>> > +	unlink (tmppath);
>> > +	return FALSE;
>> > +    }

I've now pushed up to patch 6 in the series, along with a couple of
patches to deal with SONAME related breakage.

I did end up squashing this patch in.

d

Thread: