Re: [PATCH v2 08/10] cli: add insert --must-index option

Subject: Re: [PATCH v2 08/10] cli: add insert --must-index option

Date: Wed, 09 Jul 2014 20:20:17 -0300

To: Peter Wang, notmuch@notmuchmail.org

Cc:

From: David Bremner

Peter Wang <novalazy@gmail.com> writes:

> This option causes notmuch insert to fail (with exit code 3) on failure
> to index the message, or failure to set the tags on the message, or if
> closing (flushing) the database fails.  Failure to sync tags to flags
> has no effect.

I don't really understand why it's OK to ignore failure to sync
flags. Can you explain? Or point to a previous discussion if we already
went through this?

d

• Previous message (by thread): Re: [PATCH v2 06/10] cli: refactor insert

Thread:

• Peter Wang—[PATCH v2 00/10] add insert --must-index option [inbox, unread]
  • Peter Wang—[PATCH v2 01/10] lib: add return status to database close and destroy [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v2 01/10] lib: add return status to database close and destroy [inbox, unread]
    • David Bremner—Re: [PATCH v2 01/10] lib: add return status to database close and destroy [inbox, unread]
  • Peter Wang—[PATCH v2 02/10] lib: bump soname [inbox, notmuch::patch, notmuch::pushed, unread]
  • Peter Wang—[PATCH v2 03/10] python: handle return status of database close and destroy [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v2 03/10] python: handle return status of database close and destroy [inbox, unread]
  • Peter Wang—[PATCH v2 04/10] go: add return status to database close method [inbox, notmuch::patch, notmuch::pushed, unread]
  • Peter Wang—[PATCH v2 05/10] ruby: handle return status of database close [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v2 05/10] ruby: handle return status of database close [inbox, unread]
  • Peter Wang—[PATCH v2 06/10] cli: refactor insert [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v2 06/10] cli: refactor insert [inbox, unread]
      • Peter Wang—Re: [PATCH v2 06/10] cli: refactor insert [attachment, inbox, notmuch::patch, notmuch::pushed, unread]
        • David Bremner—Re: [PATCH v2 06/10] cli: refactor insert [inbox, unread]
        • David Bremner—Re: [PATCH v2 06/10] cli: refactor insert [inbox, unread]
  • Peter Wang—[PATCH v2 07/10] cli: indicate insert failure mode in exit status [inbox, notmuch::patch, notmuch::stale, unread]
  • Peter Wang—[PATCH v2 08/10] cli: add insert --must-index option [inbox, notmuch::patch, notmuch::stale, unread]
    • David Bremner—Re: [PATCH v2 08/10] cli: add insert --must-index option [inbox, unread]
      • Peter Wang—Re: [PATCH v2 08/10] cli: add insert --must-index option [inbox, unread]
  • Peter Wang—[PATCH v2 09/10] test: test insert --must-index [inbox, notmuch::patch, notmuch::stale, unread]
  • Peter Wang—[PATCH v2 10/10] man: update insert documentation [inbox, notmuch::patch, notmuch::stale, unread]
  • Tomi Ollila—Re: [PATCH v2 00/10] add insert --must-index option [inbox, unread]