Re: [PATCH v2 06/10] cli: refactor insert

Subject: Re: [PATCH v2 06/10] cli: refactor insert

Date: Tue, 08 Jul 2014 20:24:20 -0300

To: Peter Wang


From: David Bremner

Peter Wang <> writes:

>> Is there a good reason to use TRUE and FALSE for return values rather
>> than EXIT_SUCCESS and EXIT_FAILURE? It seems like the latter would be
>> overall slightly simpler in notmuch_insert_command.
> Not sure what you have in mind.  I think CLI exit codes should be
> confined to notmuch_insert_command.

I guess I was thinking of the convention of using 0 for success; several
of the internal functions in e.g. notmuch-new.c, notmuch-dump.c an d
notmuch-restore.c and notmuch-tag.c (and of course the notmuch lib)
follow this.