Re: [PATCH v2 06/10] cli: refactor insert

Subject: Re: [PATCH v2 06/10] cli: refactor insert

Date: Tue, 08 Jul 2014 20:24:20 -0300

To: Peter Wang

Cc: notmuch@notmuchmail.org

From: David Bremner

Peter Wang <novalazy@gmail.com> writes:

>> Is there a good reason to use TRUE and FALSE for return values rather
>> than EXIT_SUCCESS and EXIT_FAILURE? It seems like the latter would be
>> overall slightly simpler in notmuch_insert_command.
>
> Not sure what you have in mind.  I think CLI exit codes should be
> confined to notmuch_insert_command.

I guess I was thinking of the convention of using 0 for success; several
of the internal functions in e.g. notmuch-new.c, notmuch-dump.c an d
notmuch-restore.c and notmuch-tag.c (and of course the notmuch lib)
follow this.

d

• Previous message (by thread): Re: [PATCH v2 06/10] cli: refactor insert

Thread:

• Peter Wang—[PATCH v2 00/10] add insert --must-index option [inbox, unread]
  • Peter Wang—[PATCH v2 01/10] lib: add return status to database close and destroy [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v2 01/10] lib: add return status to database close and destroy [inbox, unread]
    • David Bremner—Re: [PATCH v2 01/10] lib: add return status to database close and destroy [inbox, unread]
  • Peter Wang—[PATCH v2 02/10] lib: bump soname [inbox, notmuch::patch, notmuch::pushed, unread]
  • Peter Wang—[PATCH v2 03/10] python: handle return status of database close and destroy [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v2 03/10] python: handle return status of database close and destroy [inbox, unread]
  • Peter Wang—[PATCH v2 04/10] go: add return status to database close method [inbox, notmuch::patch, notmuch::pushed, unread]
  • Peter Wang—[PATCH v2 05/10] ruby: handle return status of database close [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v2 05/10] ruby: handle return status of database close [inbox, unread]
  • Peter Wang—[PATCH v2 06/10] cli: refactor insert [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v2 06/10] cli: refactor insert [inbox, unread]
      • Peter Wang—Re: [PATCH v2 06/10] cli: refactor insert [attachment, inbox, notmuch::patch, notmuch::pushed, unread]
        • David Bremner—Re: [PATCH v2 06/10] cli: refactor insert [inbox, unread]
        • David Bremner—Re: [PATCH v2 06/10] cli: refactor insert [inbox, unread]
  • Peter Wang—[PATCH v2 07/10] cli: indicate insert failure mode in exit status [inbox, notmuch::patch, notmuch::stale, unread]
  • Peter Wang—[PATCH v2 08/10] cli: add insert --must-index option [inbox, notmuch::patch, notmuch::stale, unread]
    • David Bremner—Re: [PATCH v2 08/10] cli: add insert --must-index option [inbox, unread]
      • Peter Wang—Re: [PATCH v2 08/10] cli: add insert --must-index option [inbox, unread]
  • Peter Wang—[PATCH v2 09/10] test: test insert --must-index [inbox, notmuch::patch, notmuch::stale, unread]
  • Peter Wang—[PATCH v2 10/10] man: update insert documentation [inbox, notmuch::patch, notmuch::stale, unread]
  • Tomi Ollila—Re: [PATCH v2 00/10] add insert --must-index option [inbox, unread]