On Sun, Jul 06 2014, Sebastian Lipp <bacuh@riseup.net> wrote: > Karl Fogel <kfogel@red-bean.com> writes: >> Sebastian Lipp <bacuh@riseup.net> writes: >>>diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el >>>index fa65cd5..ee7b169 100644 >>>--- a/emacs/notmuch-address.el >>>+++ b/emacs/notmuch-address.el >>>@@ -113,6 +113,59 @@ to know how address selection is made by default." >>> (when (notmuch-address-locate-command notmuch-address-command) >>> (notmuch-address-message-insinuate)) >>> >>>+;; functions to add sender / recipients to BBDB >>>+ >>>+(defvar bbdb-get-addresses-headers) >> >> I think it's good to include an initial value (even an invalid >> placeholder one, if the real initialization has not happened yet), and a >> doc string. C-h f defvar RET will say more about how to do that. > > I hope I got that right now. (I've got no real clue of Lisp yet because > I just recently switched to emacs partly because of notmuch. :) > > How about > > (defvar bbdb-get-addresses-headers nil > "List of Addresses to import into bbdb") > > ? > >> (By the way, this isn't a user-customizeable variable, right? If it >> were, then `defcustom' would be better than `defvar'.) > > As far as I understand it: It's not. someone(tm) could explain why or why-not this is defvar and not defcustom (or wice versa) so that I don't have to spend time digging into it but the bbdb-* looks a bit too generic (goes deep into bbdb "namespace" in a file not part of bbdb -package) Tomi