Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el.

Subject: Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el.

Date: Fri, 04 Jul 2014 02:38:51 +0200

To: Tomi Ollila, David Bremner, Jed Brown, Jani Nikula, Karl Fogel, Daniel Bergey

Cc: notmuch@notmuchmail.org

From: Sebastian Lipp


Tomi Ollila <tomi.ollila@iki.fi> writes:
> On Tue, Apr 09 2013, David Bremner wrote:
>> There seems to be a few warnings:
>>
>> In notmuch-bbdb/snarf-from:
>> notmuch-address.el:116:26:Warning: reference to free variable
>>     `bbdb-get-addresses-headers'
>>
>> In notmuch-bbdb/snarf-to:
>> notmuch-address.el:122:29:Warning: reference to free variable
>>     `bbdb-get-addresses-headers'
>>
>> In end of data:
>> notmuch-address.el:143:1:Warning: the following functions are not known to be
>>     defined: bbdb-get-addresses, bbdb-update-records, notmuch-show-get-header
>>
>> Do we need a few defvars?
>
> For the above set, something like:
>
> (defvar bbdb-get-addresses-headers)
>
> (declare-function notmuch-show-get-header "notmuch-show" (header &optional props))
>
> (declare-function bbdb-get-addresses "bbdb-com" 
>   (only-first-address
>    uninteresting-senders
>    get-header-content-function
>    &rest get-header-content-function-args))
>
> (declare-function bbdb-update-records "bbdb-com" (addrs auto-create-p offer-to-create))

As I'd like to see this in notmuch I made the change. The patch is
attached. As it is my first contribution to notmuch at all: Just tell me
if I'm supposed to do it in any other way.

LG
basti


Thread: