Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el.

Subject: Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el.

Date: Mon, 08 Apr 2013 07:50:38 -0300

To: Jani Nikula, Tomi Ollila, Karl Fogel

Cc: notmuch@notmuchmail.org

From: David Bremner

Jani Nikula <jani@nikula.org> writes:

> On Mon, 08 Apr 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
>> The most tolerable way is to send new patch series w/ these 2 patches
>> that apply cleanly on top of current master (661dcf87aeb70) so that the
>> things that David needs to do are just to run `git am` and `make test`.
>
> I'd say just squash the two together. We already have the old reverted
> commit that doesn't build, let's not add another commit that breaks
> bisect (= every commit must build, work, and pass tests).
>
> BR,
> Jani.

Squashed sounds good to me too. Sorry I'm too lazy/busy at the moment to
do it myself.

d

• Previous message (by thread): Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el.

Thread:

• Karl Fogel—[PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, unread]
    • Karl Fogel—Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, unread]
      • Tomi Ollila—Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, unread]
        • Jani Nikula—Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, unread]
          • David Bremner—Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, unread]
            • Jed Brown—Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, notmuch::moreinfo, notmuch::patch, unread]
              • Tomi Ollila—Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, notmuch::review, unread]
                • David Bremner—Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, unread]
                  • Tomi Ollila—Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, unread]
                    • Sebastian Lipp—Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, unread]
                      • Karl Fogel—Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, unread]
                        • Sebastian Lipp—Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, unread]
                          • Karl Fogel—Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, unread]
                            • Sebastian Lipp—Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, unread]
                              • Karl Fogel—Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, unread]
                        • Sebastian Lipp—Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, unread]
                          • Karl Fogel—Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, unread]
                          • Tomi Ollila—Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, unread]
                            • Karl Fogel—Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, unread]
                      • Tomi Ollila—Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. [inbox, unread]