Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el.

Subject: Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el.

Date: Tue, 09 Apr 2013 08:50:09 -0300

To: Tomi Ollila, Jed Brown, Jani Nikula, Karl Fogel, Daniel Bergey

Cc: notmuch@notmuchmail.org

From: David Bremner

Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Tue, Apr 09 2013, Jed Brown wrote:
>
>> David Bremner <david@tethera.net> writes:
>>
>>> Squashed sounds good to me too. Sorry I'm too lazy/busy at the moment to
>>> do it myself.
>>
>> I tested the attached and it's working as expected.  Sent as an
>> attachment to preserve author information.
>
> LGTM (this time tested, too). Also compared diffs by hand, change as announced.
> comments in id:m26207wgyt.fsf@guru.guru-group.fi (amend!) apply. 

There seems to be a few warnings:

In notmuch-bbdb/snarf-from:
notmuch-address.el:116:26:Warning: reference to free variable
    `bbdb-get-addresses-headers'

In notmuch-bbdb/snarf-to:
notmuch-address.el:122:29:Warning: reference to free variable
    `bbdb-get-addresses-headers'

In end of data:
notmuch-address.el:143:1:Warning: the following functions are not known to be
    defined: bbdb-get-addresses, bbdb-update-records, notmuch-show-get-header

Do we need a few defvars?

d

Thread: