Re: [PATCH] test: add known broken test for long directory bug

Subject: Re: [PATCH] test: add known broken test for long directory bug

Date: Thu, 18 Mar 2021 09:26:43 +0200

To: David Bremner, Gregor Zattler, notmuch

Cc:

From: Tomi Ollila


On Wed, Mar 17 2021, David Bremner wrote:

> In [1] Gregor Zattler explained the results of his hard working
> tracking down a bug in notmuch with long directories. This test
> duplicates the bug.
>
> [1]: id:20210317194728.GB5561@no.workgroup
> ---
>  test/T050-new.sh | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/test/T050-new.sh b/test/T050-new.sh
> index 76bda959..f84dc2b0 100755
> --- a/test/T050-new.sh
> +++ b/test/T050-new.sh
> @@ -339,6 +339,20 @@ test_expect_code 1 "NOTMUCH_NEW --debug 2>&1"
>  
>  notmuch config set new.tags $OLDCONFIG
>  
> +test_begin_subtest "Long directory names don't cause rescan"
> +test_subtest_known_broken
> +name=$(printf 'z%.0s' {1..234})

could do printf -v name 'z%.0s' {1..234}

> +generate_message [dir]=$name
> +NOTMUCH_NEW  > OUTPUT
> +notmuch new  >> OUTPUT

2 spaces in lines above

apart from those 2 spaces lgtm.

Tomi

> +rm -r ${MAIL_DIR}/${name}
> +notmuch new >> OUTPUT
> +cat <<EOF > EXPECTED
> +Added 1 new message to the database.
> +No new mail.
> +No new mail. Removed 1 message.
> +EOF
> +test_expect_equal_file EXPECTED OUTPUT
>  
>  test_begin_subtest "Xapian exception: read only files"
>  chmod u-w ${MAIL_DIR}/.notmuch/xapian/*.*
> -- 
> 2.30.2
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: