Re: [PATCH] lib/n_d_index_file: check return value from _n_m_add_filename

Subject: Re: [PATCH] lib/n_d_index_file: check return value from _n_m_add_filename

Date: Sun, 18 Apr 2021 10:05:09 -0300

To: Gregor Zattler, notmuch


From: David Bremner

David Bremner <> writes:

> Ignoring this return value seems like a bad idea in general, and in
> particular it has been hiding one or more bugs related to handling
> long directory names.
> ---
> This is not a fix for the aforementioned bugs, but it at least makes
> clear part of the problem.  The XDDIRENTRYnnnnn: terms are not checked
> for length in the same way as XDIRECTORY terms. It isn't clear the
> same hashing strategy will work, as the XDDIRECTORY terms are used to
> create lists of child directories. It may be the best we can do is
> enforce a limit on the length of path elements in trees indexed by
> notmuch.

Applied to master.

notmuch mailing list --
To unsubscribe send an email to