On Wed, Jun 06 2018, Daniel Kahn Gillmor wrote: > On Tue 2018-06-05 22:06:07 -0300, David Bremner wrote: >> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes: >>> + >>> +if len(sys.argv) < 2: >>> + sys.exit("""usage: {} EXPR [EXPR] >>> + >> >> the useage message doesn't seem to work? I get >> >> ╭─ zancas:software/upstream/notmuch/test >> ╰─ (git)-[master]-% python3 json_check_nodes.py >> Traceback (most recent call last): >> File "json_check_nodes.py", line 42, in <module> >> """.format(sys.argv[0])) >> KeyError: '"c"' >> >> I guess this is not tested with python2? >> >> ╭─ zancas:software/upstream/notmuch/test >> ╰─ (git)-[master]-% echo '["a", "b", {"c": 1}]' | python2 json_check_nodes.py 'second_d:[1]="d"' 'no_c:[2]!"c"' >> Traceback (most recent call last): >> File "json_check_nodes.py", line 60, in <module> >> e = 'data{}'.format(expr['address']) >> TypeError: '_sre.SRE_Match' object has no attribute '__getitem__' >> >> The test suite currently supports python2 and python3 (or at least it's >> supposed to). > > thanks for noticing these incompatibilities with python2. i've > corrected them in my working tree, and will include the fixes in the > next revision of this series. If it is going to be python2 and python3 compatible, you could add hashbang #!/usr/bin/env python and make the file executable. From tests it still can be run w/ $NOTMUCH_PYTHON but it could also work standalone should anyone(tm) want to do so... Tomi > > --dkg > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch _______________________________________________ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch