Re: Protected headers in notmuch

Subject: Re: Protected headers in notmuch

Date: Sat, 02 Jun 2018 11:25:44 -0700

To: Daniel Kahn Gillmor, Notmuch Mail

Cc:

From: Jameson Graef Rollins

I've pushed a branch of this series rebased against notmuch/release (for
some reason master is currently a couple commits behind) and fixed to
reflect the exposure of notmuch_message_get_database:

https://gitlab.com/jrollins/notmuch/commits/protected-headers-fix

All tests pass.  Note it requires gmime 3.0 (which tripped me up for a
bit since notmuch still implicitly supports older gmime versions).

I haven't done a commit-by-commit review yet, but I am now using this
series and it works as advertised: messages with encrypted subjects are
searchable by the encrypted subject, and the encrypted subjects show up
correctly in all the clients I'm using (both CLI and emacs).

I strongly support the inclusion of this feature, particularly since
it's an important component of autocrypt, which I want even more.

jamie.

_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

• Previous message (by thread): Re: Protected headers in notmuch

Thread:

• Daniel Kahn Gillmor—Protected headers in notmuch [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 01/20] test: new test framework to compare json parts [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 01/20] test: new test framework to compare json parts [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH 01/20] test: new test framework to compare json parts [inbox, signed, unread]
        • David Bremner—Re: [PATCH 01/20] test: new test framework to compare json parts [inbox, unread]
          • Daniel Kahn Gillmor—Re: [PATCH 01/20] test: new test framework to compare json parts [inbox, unread]
        • Tomi Ollila—Re: [PATCH 01/20] test: new test framework to compare json parts [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 02/20] crypto: Avoid pretending to verify signatures on unsigned encrypted mail [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 03/20] cli/show: pass the siglist directly to the sigstatus sprinter [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 04/20] util/crypto: _notmuch_message_crypto: tracks message-wide crypto state [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 04/20] util/crypto: _notmuch_message_crypto: tracks message-wide crypto state [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH 04/20] util/crypto: _notmuch_message_crypto: tracks message-wide crypto state [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 05/20] cli: expose message-wide crypto status from mime-node [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 06/20] mime-node: track whole-message crypto state while walking the tree [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 06/20] mime-node: track whole-message crypto state while walking the tree [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 07/20] cli/show: emit new whole-message crypto status output [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 07/20] cli/show: emit new whole-message crypto status output [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH 07/20] cli/show: emit new whole-message crypto status output [inbox, signed, unread]
        • David Bremner—Re: [PATCH 07/20] cli/show: emit new whole-message crypto status output [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 08/20] cli/show: emit headers after emitting body [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 08/20] cli/show: emit headers after emitting body [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 09/20] util/crypto: add information about the payload part [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 09/20] util/crypto: add information about the payload part [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH 09/20] util/crypto: add information about the payload part [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 10/20] cli/show: add tests for viewing protected headers [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 10/20] cli/show: add tests for viewing protected headers [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH 10/20] cli/show: add tests for viewing protected headers [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 11/20] cli/show: emit payload subject instead of outside subject [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 11/20] cli/show: emit payload subject instead of outside subject [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH 11/20] cli/show: emit payload subject instead of outside subject [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 12/20] cli/show: add information about which headers were protected [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 12/20] cli/show: add information about which headers were protected [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 13/20] test: add test for missing external subject [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 14/20] test: show cryptographic envelope information for signed mails [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 14/20] test: show cryptographic envelope information for signed mails [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 15/20] cli/reply: ensure encrypted Subject: line does not leak in the clear [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 16/20] cli: introduce flags for format_headers_sprinter [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 17/20] cli/reply: add --protected-subject boolean flag [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 17/20] cli/reply: add --protected-subject boolean flag [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 18/20] indexing: record protected subject when indexing cleartext [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jameson Graef Rollins—Re: [PATCH 18/20] indexing: record protected subject when indexing cleartext [inbox, signed, unread]
  • Daniel Kahn Gillmor—[PATCH 19/20] test: protected headers should work when both encrypted and signed. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 20/20] test: after reindexing, only legitimate protected subjects are searchable [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jameson Graef Rollins—Re: Protected headers in notmuch [inbox, signed, unread]
    • David Bremner—Re: Protected headers in notmuch [inbox, unread]
      • Daniel Kahn Gillmor—Re: Protected headers in notmuch [inbox, signed, unread]
      • David Bremner—Re: Protected headers in notmuch [inbox, unread]
    • Jameson Graef Rollins—Re: Protected headers in notmuch [inbox, signed, unread]
  • David Bremner—Re: Protected headers in notmuch [inbox, unread]