Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

Subject: Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

Date: Mon, 23 Jan 2012 17:55:14 +0000

To: Jameson Graef Rollins, Notmuch Mail

Cc:

From: David Edmondson

On Mon, 23 Jan 2012 09:39:30 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> On Mon, 23 Jan 2012 11:02:04 +0000, David Edmondson <dme@dme.org> wrote:
> > On Mon, 23 Jan 2012 00:34:23 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> > > -(defun notmuch-show-next-open-message ()
> > > +(defun notmuch-show-next-open-message (&optional pop-at-end)
> > >    "Show the next message."
> > > -  (interactive)
> > > -  (let (r)
> > > +  (interactive "P")
> > > +  (let ((parent-buffer notmuch-show-parent-buffer)
> > > +	(r))
> > 
> > Extra brackets around 'r' are unnecessary. Otherwise, +1.
> 
> This seems minor enough that I'm not going to resend, but noted for next
> time.  Thanks.

On that basis, I hope no-one will complain if I fix them as a 'drive by'
during another change...

• Previous message (by thread): Re:

Thread:

• Jameson Graef Rollins—show-mode message/thread archiving improvements [inbox, signed, unread]
  • Jameson Graef Rollins—[PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jameson Graef Rollins—[PATCH 2/6] emacs: break out thread navigation from notmuch-show-archive-thread [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Jameson Graef Rollins—[PATCH 3/6] emacs: add message archiving functions [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Jameson Graef Rollins—[PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, notmuch::obsolete, notmuch::patch, unread]
          • Jameson Graef Rollins—[PATCH 5/6] emacs: use pop-at-end functionality in show-archive-message-then-next function [inbox, notmuch::obsolete, notmuch::patch, unread]
            • Jameson Graef Rollins—[PATCH 6/6] emacs: modify the default show-mode key bindings for archiving [inbox, notmuch::obsolete, notmuch::patch, unread]
              • David Edmondson—Re: [PATCH 6/6] emacs: modify the default show-mode key bindings for archiving [inbox, signed, unread]
          • David Edmondson—Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, notmuch::review, signed, unread]
            • Jameson Graef Rollins—Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, signed, unread]
              • David Edmondson—Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, signed, unread]
                • Jameson Graef Rollins—Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, signed, unread]
        • Jameson Graef Rollins—[PATCH] emacs: fix archive thread/message function documentation. [inbox, notmuch::patch, notmuch::pushed, unread]
        • Aaron Ecay—Re: [PATCH 3/6] emacs: add message archiving functions [inbox, notmuch::review, unread]
          • Jameson Graef Rollins—Re: [PATCH 3/6] emacs: add message archiving functions [inbox, signed, unread]
        • David Edmondson—Re: [PATCH 3/6] emacs: add message archiving functions [inbox, notmuch::review, signed, unread]
      • David Edmondson—Re: [PATCH 2/6] emacs: break out thread navigation from notmuch-show-archive-thread [inbox, notmuch::review, signed, unread]
    • Aaron Ecay—Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions [inbox, notmuch::review, unread]
      • Jameson Graef Rollins—Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions [inbox, signed, unread]
        • Aaron Ecay—Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions [inbox, unread]
        • David Edmondson—Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions [inbox, signed, unread]
    • David Edmondson—Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions [inbox, signed, unread]
  • Aaron Ecay—Re: show-mode message/thread archiving improvements [inbox, unread]
  • Jameson Graef Rollins—Re: show-mode message/thread archiving improvements [inbox, signed, unread]
    • Jameson Graef Rollins—[PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two more generally useful functions [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Jameson Graef Rollins—[PATCH 2/6] emacs: break out thread navigation from notmuch-show-archive-thread [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Jameson Graef Rollins—[PATCH 3/6] emacs: add message archiving functions [inbox, notmuch::obsolete, notmuch::patch, unread]
          • Jameson Graef Rollins—[PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, notmuch::obsolete, notmuch::patch, unread]
            • Jameson Graef Rollins—[PATCH 5/6] emacs: use pop-at-end functionality in show-archive-message-then-next function [inbox, notmuch::obsolete, notmuch::patch, unread]
              • Jameson Graef Rollins—[PATCH 6/6] emacs: modify the default show-mode key bindings for archiving [inbox, notmuch::obsolete, notmuch::patch, unread]
                • David Edmondson—Re: [PATCH 6/6] emacs: modify the default show-mode key bindings for archiving [inbox, notmuch::review, signed, unread]
                • Xavier Maillard—Re: [PATCH 6/6] emacs: modify the default show-mode key bindings for archiving [inbox, unread]
                • Tomi Ollila—Re: [PATCH 6/6] emacs: modify the default show-mode key bindings for archiving [inbox, unread]
            • David Edmondson—Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, signed, unread]
              • Jameson Graef Rollins—Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, signed, unread]
                • David Edmondson—Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, signed, unread]
                  • Jameson Graef Rollins—Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, signed, unread]
          • David Edmondson—Re: [PATCH 3/6] emacs: add message archiving functions [inbox, signed, unread]
          • Tomi Ollila—Re: [PATCH 3/6] emacs: add message archiving functions [inbox, unread]
        • David Edmondson—Re: [PATCH 2/6] emacs: break out thread navigation from notmuch-show-archive-thread [inbox, notmuch::review, signed, unread]
      • David Edmondson—Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two more generally useful functions [inbox, signed, unread]
    • Jameson Graef Rollins— [inbox, unread]
      • Jameson Graef Rollins—[PATCH v3 1/8] emacs: use search-next-thread to move to next thread in show mode [inbox, notmuch::patch, notmuch::pushed, unread]
        • Jameson Graef Rollins—[PATCH v3 2/8] emacs: break up notmuch-show-archive-thread-internal into two more generally useful functions [inbox, notmuch::patch, notmuch::pushed, unread]
          • Jameson Graef Rollins—[PATCH v3 3/8] emacs: break out thread navigation from notmuch-show-archive-thread [inbox, notmuch::patch, notmuch::pushed, unread]
            • Jameson Graef Rollins—[PATCH v3 4/8] emacs: add message archiving functions [inbox, notmuch::patch, notmuch::pushed, unread]
              • Jameson Graef Rollins—[PATCH v3 5/8] emacs: add option to show-next-{, open-}message functions to pop out to parent buffer if at end [inbox, notmuch::patch, notmuch::pushed, unread]
                • Jameson Graef Rollins—[PATCH v3 6/8] emacs: use pop-at-end functionality in show-archive-message-then-next function [inbox, notmuch::patch, notmuch::pushed, unread]
                  • Jameson Graef Rollins—[PATCH v3 7/8] emacs: modify the default show-mode key bindings for archiving [inbox, notmuch::patch, notmuch::pushed, unread]
                    • Jameson Graef Rollins—[PATCH v3 8/8] emacs: fix show-previous-message doc string [inbox, notmuch::patch, notmuch::pushed, unread]
                      • David Edmondson—Re: [PATCH v3 8/8] emacs: fix show-previous-message doc string [inbox, notmuch::review, signed, unread]
                    • David Edmondson—Re: [PATCH v3 7/8] emacs: modify the default show-mode key bindings for archiving [inbox, notmuch::review, signed, unread]
                  • David Edmondson—Re: [PATCH v3 6/8] emacs: use pop-at-end functionality in show-archive-message-then-next function [inbox, notmuch::review, signed, unread]
                • David Edmondson—Re: [PATCH v3 5/8] emacs: add option to show-next-{, open-}message functions to pop out to parent buffer if at end [inbox, notmuch::review, signed, unread]
              • David Edmondson—Re: [PATCH v3 4/8] emacs: add message archiving functions [inbox, notmuch::review, signed, unread]
            • David Edmondson—Re: [PATCH v3 3/8] emacs: break out thread navigation from notmuch-show-archive-thread [inbox, notmuch::review, signed, unread]
          • David Edmondson—Re: [PATCH v3 2/8] emacs: break up notmuch-show-archive-thread-internal into two more generally useful functions [inbox, notmuch::review, signed, unread]
        • David Edmondson—Re: [PATCH v3 1/8] emacs: use search-next-thread to move to next thread in show mode [inbox, notmuch::review, signed, unread]
      • David Bremner—Re: [inbox, unread]