Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

Subject: Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

Date: Mon, 23 Jan 2012 10:51:06 -0800

To: David Edmondson, Notmuch Mail

Cc:

From: Jameson Graef Rollins


On Mon, 23 Jan 2012 17:55:14 +0000, David Edmondson <dme@dme.org> wrote:
> On that basis, I hope no-one will complain if I fix them as a 'drive by'
> during another change...

Hrm.  I don't think that follows.  Unless the patch is already touching
that code, I would really prefer we continue to enforce that unrelated
changes go into separate patches.

There are plenty of other places in the code where we do use parens
around uninitialized variables.  If you really want to remove them I
would prefer to see a patch to fixes them all at once.  Doesn't seem
worth it to me, but everyone seems to be on an uncrustify kick recently,
so...

jamie.
part-000.sig (application/pgp-signature)

Thread: