Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions

Subject: Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions

Date: Wed, 18 Jan 2012 08:06:58 +0000

To: Jameson Graef Rollins, Notmuch Mail

Cc:

From: David Edmondson

Very happy with the overall ideas.

On Tue, 17 Jan 2012 10:05:26 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> -(defun notmuch-show-archive-thread-internal (show-next)
> -  ;; Remove the tag from the current set of messages.
> +(defun notmuch-show-tag-thread-internal (tag &optional remove)
> +  ;; Add tag to the current set of messages.  If the remove switch is
> +  ;; given, tags will be removed instead of added.
>    (goto-char (point-min))
> -  (loop do (notmuch-show-remove-tag "inbox")
> -	until (not (notmuch-show-goto-message-next)))
> -  ;; Move to the next item in the search results, if any.
> +  (let ((tag-function 'notmuch-show-add-tag))
> +    (if remove
> +	(setq tag-function 'notmuch-show-remove-tag))

This seems odd. How about:

 (let ((tag-function (if remove 'notmuch-show-remove-tag 'notmuch-show-add-tag)))
  ...

> +    (loop do (funcall tag-function tag)
> +	  until (not (notmuch-show-goto-message-next)))))

Otherwise good.

• Previous message (by thread): Re:

Thread:

• Jameson Graef Rollins—show-mode message/thread archiving improvements [inbox, signed, unread]
  • Jameson Graef Rollins—[PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jameson Graef Rollins—[PATCH 2/6] emacs: break out thread navigation from notmuch-show-archive-thread [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Jameson Graef Rollins—[PATCH 3/6] emacs: add message archiving functions [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Jameson Graef Rollins—[PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, notmuch::obsolete, notmuch::patch, unread]
          • Jameson Graef Rollins—[PATCH 5/6] emacs: use pop-at-end functionality in show-archive-message-then-next function [inbox, notmuch::obsolete, notmuch::patch, unread]
            • Jameson Graef Rollins—[PATCH 6/6] emacs: modify the default show-mode key bindings for archiving [inbox, notmuch::obsolete, notmuch::patch, unread]
              • David Edmondson—Re: [PATCH 6/6] emacs: modify the default show-mode key bindings for archiving [inbox, signed, unread]
          • David Edmondson—Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, notmuch::review, signed, unread]
            • Jameson Graef Rollins—Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, signed, unread]
              • David Edmondson—Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, signed, unread]
                • Jameson Graef Rollins—Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, signed, unread]
        • Jameson Graef Rollins—[PATCH] emacs: fix archive thread/message function documentation. [inbox, notmuch::patch, notmuch::pushed, unread]
        • Aaron Ecay—Re: [PATCH 3/6] emacs: add message archiving functions [inbox, notmuch::review, unread]
          • Jameson Graef Rollins—Re: [PATCH 3/6] emacs: add message archiving functions [inbox, signed, unread]
        • David Edmondson—Re: [PATCH 3/6] emacs: add message archiving functions [inbox, notmuch::review, signed, unread]
      • David Edmondson—Re: [PATCH 2/6] emacs: break out thread navigation from notmuch-show-archive-thread [inbox, notmuch::review, signed, unread]
    • Aaron Ecay—Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions [inbox, notmuch::review, unread]
      • Jameson Graef Rollins—Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions [inbox, signed, unread]
        • Aaron Ecay—Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions [inbox, unread]
        • David Edmondson—Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions [inbox, signed, unread]
    • David Edmondson—Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions [inbox, signed, unread]
  • Aaron Ecay—Re: show-mode message/thread archiving improvements [inbox, unread]
  • Jameson Graef Rollins—Re: show-mode message/thread archiving improvements [inbox, signed, unread]
    • Jameson Graef Rollins—[PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two more generally useful functions [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Jameson Graef Rollins—[PATCH 2/6] emacs: break out thread navigation from notmuch-show-archive-thread [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Jameson Graef Rollins—[PATCH 3/6] emacs: add message archiving functions [inbox, notmuch::obsolete, notmuch::patch, unread]
          • Jameson Graef Rollins—[PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, notmuch::obsolete, notmuch::patch, unread]
            • Jameson Graef Rollins—[PATCH 5/6] emacs: use pop-at-end functionality in show-archive-message-then-next function [inbox, notmuch::obsolete, notmuch::patch, unread]
              • Jameson Graef Rollins—[PATCH 6/6] emacs: modify the default show-mode key bindings for archiving [inbox, notmuch::obsolete, notmuch::patch, unread]
                • David Edmondson—Re: [PATCH 6/6] emacs: modify the default show-mode key bindings for archiving [inbox, notmuch::review, signed, unread]
                • Xavier Maillard—Re: [PATCH 6/6] emacs: modify the default show-mode key bindings for archiving [inbox, unread]
                • Tomi Ollila—Re: [PATCH 6/6] emacs: modify the default show-mode key bindings for archiving [inbox, unread]
            • David Edmondson—Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, signed, unread]
              • Jameson Graef Rollins—Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, signed, unread]
                • David Edmondson—Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, signed, unread]
                  • Jameson Graef Rollins—Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, signed, unread]
          • David Edmondson—Re: [PATCH 3/6] emacs: add message archiving functions [inbox, signed, unread]
          • Tomi Ollila—Re: [PATCH 3/6] emacs: add message archiving functions [inbox, unread]
        • David Edmondson—Re: [PATCH 2/6] emacs: break out thread navigation from notmuch-show-archive-thread [inbox, notmuch::review, signed, unread]
      • David Edmondson—Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two more generally useful functions [inbox, signed, unread]
    • Jameson Graef Rollins— [inbox, unread]
      • Jameson Graef Rollins—[PATCH v3 1/8] emacs: use search-next-thread to move to next thread in show mode [inbox, notmuch::patch, notmuch::pushed, unread]
        • Jameson Graef Rollins—[PATCH v3 2/8] emacs: break up notmuch-show-archive-thread-internal into two more generally useful functions [inbox, notmuch::patch, notmuch::pushed, unread]
          • Jameson Graef Rollins—[PATCH v3 3/8] emacs: break out thread navigation from notmuch-show-archive-thread [inbox, notmuch::patch, notmuch::pushed, unread]
            • Jameson Graef Rollins—[PATCH v3 4/8] emacs: add message archiving functions [inbox, notmuch::patch, notmuch::pushed, unread]
              • Jameson Graef Rollins—[PATCH v3 5/8] emacs: add option to show-next-{, open-}message functions to pop out to parent buffer if at end [inbox, notmuch::patch, notmuch::pushed, unread]
                • Jameson Graef Rollins—[PATCH v3 6/8] emacs: use pop-at-end functionality in show-archive-message-then-next function [inbox, notmuch::patch, notmuch::pushed, unread]
                  • Jameson Graef Rollins—[PATCH v3 7/8] emacs: modify the default show-mode key bindings for archiving [inbox, notmuch::patch, notmuch::pushed, unread]
                    • Jameson Graef Rollins—[PATCH v3 8/8] emacs: fix show-previous-message doc string [inbox, notmuch::patch, notmuch::pushed, unread]
                      • David Edmondson—Re: [PATCH v3 8/8] emacs: fix show-previous-message doc string [inbox, notmuch::review, signed, unread]
                    • David Edmondson—Re: [PATCH v3 7/8] emacs: modify the default show-mode key bindings for archiving [inbox, notmuch::review, signed, unread]
                  • David Edmondson—Re: [PATCH v3 6/8] emacs: use pop-at-end functionality in show-archive-message-then-next function [inbox, notmuch::review, signed, unread]
                • David Edmondson—Re: [PATCH v3 5/8] emacs: add option to show-next-{, open-}message functions to pop out to parent buffer if at end [inbox, notmuch::review, signed, unread]
              • David Edmondson—Re: [PATCH v3 4/8] emacs: add message archiving functions [inbox, notmuch::review, signed, unread]
            • David Edmondson—Re: [PATCH v3 3/8] emacs: break out thread navigation from notmuch-show-archive-thread [inbox, notmuch::review, signed, unread]
          • David Edmondson—Re: [PATCH v3 2/8] emacs: break up notmuch-show-archive-thread-internal into two more generally useful functions [inbox, notmuch::review, signed, unread]
        • David Edmondson—Re: [PATCH v3 1/8] emacs: use search-next-thread to move to next thread in show mode [inbox, notmuch::review, signed, unread]
      • David Bremner—Re: [inbox, unread]