Re: [PATCH v4 2/3] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists

Subject: Re: [PATCH v4 2/3] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists

Date: Wed, 07 May 2014 16:22:53 +0100

To: Pieter Praet

Cc: Notmuch Mail

From: David Edmondson

[ Trimmed to/cc list. ]

On Sun, Jan 22 2012, Pieter Praet wrote:
> * emacs/notmuch-show.el (notmuch-show-found-target-p): new predicate function
>   that uses notmuch(1) 'count' to see if a query turns up any results.
> * emacs/notmuch-show.el (notmuch-show-if-found): new function that only shows
>   a message/thread if present in the database and otherwise returns an error.
> * emacs/notmuch-show.el (notmuch-show-buttonize-links): some deduplication,
>   and use new function `notmuch-show-if-found' instead of `notmuch-show'
>   to prevent showing a blank screen for Message-Id's which aren't present
>   in the database.

Mark provided some feedback about this (relating to exclusions), but
more generally there is a problem that `M-x notmuch-show id:doesntexist'
will result in an error ("notmuch-show-message-top: Beginning of
buffer"). That seems like a bug that should be fixed.
signature.asc (application/pgp-signature)