Re: [PATCH 3/3] emacs: colorize buttonized 'id:' links depending on the target message's state

Subject: Re: [PATCH 3/3] emacs: colorize buttonized 'id:' links depending on the target message's state

Date: Mon, 16 Jan 2012 11:45:13 +0000

To: Pieter Praet, Jameson Graef Rollins

Cc: Notmuch Mail

From: David Edmondson

On Thu, 12 Jan 2012 18:23:45 +0100, Pieter Praet <pieter@praet.org> wrote:
> +			'face (cond
> +			       ((notmuch-show-found-target-p message-id t)
> +				'notmuch-show-buttonized-link-present-and-unread)
> +			       ((notmuch-show-found-target-p message-id)
> +				'notmuch-show-buttonized-link-present)
> +			       (t 'notmuch-show-buttonized-link-missing)))))))

I like it, but worry a bit more about the performance (we're up to two
'notmuch' invocations for a missing or read message).

• Previous message (by thread): Re: [PATCH v4 2/3] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists

Thread:

• Jameson Graef Rollins—[PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  • David Edmondson—Re: [PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links [inbox, signed, unread]
    • Xavier Maillard—Re: [PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links [inbox, unread]
      • David Edmondson—Re: [PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links [inbox, signed, unread]
  • David Bremner—Re: [PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links [inbox, unread]
  • Pieter Praet—Re: [PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links [inbox, notmuch::bug, notmuch::fixed, notmuch::review, unread]
    • Pieter Praet—[PATCH 1/3] emacs: s/buttonise/buttonize/g [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
      • Pieter Praet—[PATCH 2/3] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
        • David Edmondson—Re: [PATCH 2/3] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists [inbox, notmuch::review, signed, unread]
          • Pieter Praet—Re: [PATCH 2/3] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists [inbox, unread]
            • Pieter Praet—[PATCH v2] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
              • David Edmondson—Re: [PATCH v2] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists [inbox, notmuch::review, signed, unread]
      • Pieter Praet—[PATCH 3/3] emacs: colorize buttonized 'id:' links depending on the target message's state [inbox, notmuch::emacs, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
        • David Edmondson—Re: [PATCH 3/3] emacs: colorize buttonized 'id:' links depending on the target message's state [inbox, signed, unread]
          • Pieter Praet—Re: [PATCH 3/3] emacs: colorize buttonized 'id:' links depending on the target message's state [inbox, unread]
          • Pieter Praet—Re: [PATCH 3/3] emacs: colorize buttonized 'id:' links depending on the target message's state [inbox, unread]
            • Pieter Praet—[PATCH] v2 emacs: colorize buttonized 'id:' links depending on the target message's state [inbox, notmuch::emacs, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
              • David Edmondson—Re: [PATCH] v2 emacs: colorize buttonized 'id:' links depending on the target message's state [inbox, signed, unread]
              • Aaron Ecay—Re: [PATCH] v2 emacs: colorize buttonized 'id:' links depending on the target message's state [inbox, unread]
                • Pieter Praet—Re: [PATCH] v2 emacs: colorize buttonized 'id:' links depending on the target message's state [inbox, unread]
                  • Pieter Praet—[PATCH 3/3 v3] emacs: colorize buttonized 'id:' links depending on the target message's state [inbox, notmuch::emacs, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
                  • Mark Anderson—Re: [PATCH] v2 emacs: colorize buttonized 'id:' links depending on the target message's state [inbox, unread]
                    • Pieter Praet—Re: [PATCH] v2 emacs: colorize buttonized 'id:' links depending on the target message's state [inbox, unread]
                      • Pieter Praet—[PATCH v4 1/3] emacs: s/buttonise/buttonize/g [inbox, notmuch::patch, notmuch::stale, notmuch::trivial, notmuch::wip, unread]
                      • Pieter Praet—[PATCH v4 2/3] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists [inbox, notmuch::emacs, notmuch::fix, notmuch::patch, notmuch::stale, notmuch::wip, unread]
                        • Mark Walters—Re: [PATCH v4 2/3] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists [inbox, notmuch::review, unread]
                          • Pieter Praet—Re: [PATCH v4 2/3] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists [inbox, unread]
                        • David Edmondson—Re: [PATCH v4 2/3] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists [inbox, notmuch::bug, notmuch::fixed, signed, unread]
                          • David Bremner—Re: [PATCH v4 2/3] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists [inbox, unread]
                      • Pieter Praet—[PATCH v4 3/3] emacs: colorize buttonized 'id:' links depending on the target message's state [inbox, notmuch::emacs, notmuch::feature, notmuch::patch, notmuch::stale, notmuch::wip, unread]
      • David Edmondson—Re: [PATCH 1/3] emacs: s/buttonise/buttonize/g [inbox, notmuch::review, signed, unread]
      • David Bremner—Re: [PATCH 1/3] emacs: s/buttonise/buttonize/g [inbox, unread]
        • Pieter Praet—Re: [PATCH 1/3] emacs: s/buttonise/buttonize/g [inbox, unread]
          • Tomi Ollila—Re: [PATCH 1/3] emacs: s/buttonise/buttonize/g [inbox, unread]
    • David Bremner—Re: [PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links [inbox, unread]