Re: [PATCH 1/2] add notmuch keybinding 'd'

Subject: Re: [PATCH 1/2] add notmuch keybinding 'd'

Date: Wed, 04 Jan 2012 08:52:13 +0000

To: Antoine Beaupré, notmuch@notmuchmail.org

Cc:

From: David Edmondson

On Tue, 03 Jan 2012 14:56:50 +0000, David Edmondson <dme@dme.org> wrote:
> On Sat, 16 Jul 2011 14:39:59 -0400, Antoine Beaupré <anarcat@koumbit.org> wrote:
> > It adds a tag 'deleted' and removes the tags 'inbox' and 'unread'. It
> > works in show as well as in search mode
> 
> Various people have asked for a keybinding to add a 'delete' tag. Is
> this version the right one to choose?

No-one has spoken up in favour of this particular change (and the removal
of "unread" seems questionable) so I plan to mark it 'obsolete'. If
anyone would like to bring it back, please post an updated version of
the patch and argue for it.

• Previous message (by thread): Re: [PATCH 1/2] add notmuch keybinding 'd'

Thread:

• Jesse Rosenthal—[notmuch] [PATCH] notmuch.el: add functionality to add or remove tags by region. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jesse Rosenthal—Re: [notmuch] [PATCH] notmuch.el: add functionality to add or remove tags by region. [inbox, unread]
  • Jameson Rollins—Re: [notmuch] [PATCH] notmuch.el: add functionality to add or remove tags by region. [inbox, signed, unread]
    • Jesse Rosenthal—Re: [notmuch] [PATCH] notmuch.el: add functionality to add or remove tags by region. [inbox, unread]
      • Jameson Rollins—Re: [notmuch] [PATCH] notmuch.el: add functionality to add or remove tags by region. [inbox, unread]
        • Jesse Rosenthal—Re: [notmuch] [PATCH] notmuch.el: add functionality to add or remove tags by region. [inbox, unread]
          • Jesse Rosenthal—Re: [notmuch] [PATCH] notmuch.el: add functionality to add or remove tags by region. [inbox, unread]
  • Jesse Rosenthal—[notmuch] [PATCH v2] notmuch.el: add functionality in notmuch search mode to add or remove tags by region [inbox, notmuch::patch, notmuch::pushed, unread]
    • Sebastian Spaeth—[notmuch] [PATCH] notmuch.el: bind 'd' to new function notmuch-search-delete-thread-or-region [inbox, notmuch::obsolete, notmuch::patch, unread]
      • anarcat—Re: notmuch.el: bind 'd' to new function notmuch-search-delete-thread-or-region [inbox, signed, unread]
        • Matthieu Lemerre—Re: notmuch.el: bind 'd' to new function notmuch-search-delete-thread-or-region [inbox, unread]
      • Antoine Beaupré—[PATCH 1/2] add notmuch keybinding 'd' [inbox, notmuch::obsolete, notmuch::patch, unread]
        • David Edmondson—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, signed, unread]
          • Jani Nikula—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, unread]
            • Jameson Graef Rollins—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, signed, unread]
              • Jani Nikula—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, unread]
            • Antoine Beaupré—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, signed, unread]
              • Jameson Graef Rollins—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, signed, unread]
              • David Bremner—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, unread]
                • Antoine Beaupré—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, signed, unread]
              • Jani Nikula—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, unread]
              • Tomi Ollila—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, unread]
          • David Edmondson—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, signed, unread]
            • Antoine Beaupré—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, signed, unread]
    • Carl Worth—Re: [notmuch] [PATCH v2] notmuch.el: add functionality in notmuch search mode to add or remove tags by region [inbox, notmuch::review, signed, unread]
      • Jesse Rosenthal—Re: [notmuch] [PATCH v2] notmuch.el: add functionality in notmuch search mode to add or remove tags by region [inbox, unread]
        • Carl Worth—Re: [notmuch] [PATCH v2] notmuch.el: add functionality in notmuch search mode to add or remove tags by region [inbox, signed, unread]
          • Jesse Rosenthal—Re: [notmuch] [PATCH v2] notmuch.el: add functionality in notmuch search mode to add or remove tags by region [inbox, unread]
          • Jesse Rosenthal—[PATCH] Fix bug, and clean up code duplication, in adding or removing tag by region. [inbox, notmuch::patch, notmuch::pushed, unread]
            • Carl Worth—Re: [PATCH] Fix bug, and clean up code duplication, in adding or removing tag by region. [inbox, signed, unread]
              • Jesse Rosenthal—Re: [PATCH] Fix bug, and clean up code duplication, in adding or removing tag by region. [inbox, unread]
                • Mark Anderson—Re: [PATCH] Fix bug, and clean up code duplication, in adding or removing tag by region. [inbox, unread]