Re: [notmuch] [PATCH] notmuch.el: add functionality to add or remove tags by region.

Subject: Re: [notmuch] [PATCH] notmuch.el: add functionality to add or remove tags by region.

Date: Thu, 21 Jan 2010 10:23:24 -0500

To: Jesse Rosenthal

Cc: notmuch@notmuchmail.org

From: Jameson Rollins

On Wed, Jan 20, 2010 at 03:58:10PM -0500, Jesse Rosenthal wrote:
> This patch adds `-region' versions of the `notmuch-search-' commands to find properties. It also splits up  `notmuch-add/remove-tags' into both a `-thread' and a `-region' version. (This makes us modify `notmuch-search-archive-thread' to use the `notmuch-search-remove-tag-thread' function, instead of `notmuch-search-remove-tag', for consistency.) The add/remove-tag command called by pressing `+' or `-' will then choose accordingly, based on whether region is active.

Hi, Jesse.  Can you explain what exactly a "region" is?  It's not
clear from your log message or the patch itself.

jamie.

• Previous message (by thread): Re: [PATCH 1/2] add notmuch keybinding 'd'

Thread:

• Jesse Rosenthal—[notmuch] [PATCH] notmuch.el: add functionality to add or remove tags by region. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jesse Rosenthal—Re: [notmuch] [PATCH] notmuch.el: add functionality to add or remove tags by region. [inbox, unread]
  • Jameson Rollins—Re: [notmuch] [PATCH] notmuch.el: add functionality to add or remove tags by region. [inbox, signed, unread]
    • Jesse Rosenthal—Re: [notmuch] [PATCH] notmuch.el: add functionality to add or remove tags by region. [inbox, unread]
      • Jameson Rollins—Re: [notmuch] [PATCH] notmuch.el: add functionality to add or remove tags by region. [inbox, unread]
        • Jesse Rosenthal—Re: [notmuch] [PATCH] notmuch.el: add functionality to add or remove tags by region. [inbox, unread]
          • Jesse Rosenthal—Re: [notmuch] [PATCH] notmuch.el: add functionality to add or remove tags by region. [inbox, unread]
  • Jesse Rosenthal—[notmuch] [PATCH v2] notmuch.el: add functionality in notmuch search mode to add or remove tags by region [inbox, notmuch::patch, notmuch::pushed, unread]
    • Sebastian Spaeth—[notmuch] [PATCH] notmuch.el: bind 'd' to new function notmuch-search-delete-thread-or-region [inbox, notmuch::obsolete, notmuch::patch, unread]
      • anarcat—Re: notmuch.el: bind 'd' to new function notmuch-search-delete-thread-or-region [inbox, signed, unread]
        • Matthieu Lemerre—Re: notmuch.el: bind 'd' to new function notmuch-search-delete-thread-or-region [inbox, unread]
      • Antoine Beaupré—[PATCH 1/2] add notmuch keybinding 'd' [inbox, notmuch::obsolete, notmuch::patch, unread]
        • David Edmondson—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, signed, unread]
          • Jani Nikula—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, unread]
            • Jameson Graef Rollins—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, signed, unread]
              • Jani Nikula—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, unread]
            • Antoine Beaupré—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, signed, unread]
              • Jameson Graef Rollins—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, signed, unread]
              • David Bremner—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, unread]
                • Antoine Beaupré—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, signed, unread]
              • Jani Nikula—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, unread]
              • Tomi Ollila—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, unread]
          • David Edmondson—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, signed, unread]
            • Antoine Beaupré—Re: [PATCH 1/2] add notmuch keybinding 'd' [inbox, signed, unread]
    • Carl Worth—Re: [notmuch] [PATCH v2] notmuch.el: add functionality in notmuch search mode to add or remove tags by region [inbox, notmuch::review, signed, unread]
      • Jesse Rosenthal—Re: [notmuch] [PATCH v2] notmuch.el: add functionality in notmuch search mode to add or remove tags by region [inbox, unread]
        • Carl Worth—Re: [notmuch] [PATCH v2] notmuch.el: add functionality in notmuch search mode to add or remove tags by region [inbox, signed, unread]
          • Jesse Rosenthal—Re: [notmuch] [PATCH v2] notmuch.el: add functionality in notmuch search mode to add or remove tags by region [inbox, unread]
          • Jesse Rosenthal—[PATCH] Fix bug, and clean up code duplication, in adding or removing tag by region. [inbox, notmuch::patch, notmuch::pushed, unread]
            • Carl Worth—Re: [PATCH] Fix bug, and clean up code duplication, in adding or removing tag by region. [inbox, signed, unread]
              • Jesse Rosenthal—Re: [PATCH] Fix bug, and clean up code duplication, in adding or removing tag by region. [inbox, unread]
                • Mark Anderson—Re: [PATCH] Fix bug, and clean up code duplication, in adding or removing tag by region. [inbox, unread]