Re: [PATCH] Fix bug, and clean up code duplication, in adding or removing tag by region.

Subject: Re: [PATCH] Fix bug, and clean up code duplication, in adding or removing tag by region.

Date: Wed, 14 Apr 2010 13:23:11 -0600

To: Jesse Rosenthal, Carl Worth, notmuch@notmuchmail.org

Cc:

From: Mark Anderson


On Wed, 14 Apr 2010 12:50:50 -0500, Jesse Rosenthal <jrosenthal@jhu.edu> wrote:
> It occurs to me that the best way to do this would probably be to go to
> point-max, and then (forward-line -1) until we hit a thread-id. That way
> we wouldn't have to work all the way down long search indexes. I'll try
> to code that up for the next release, and then have
> notmuch-search-last-thread use it, as well as the region functions.

This sounds great, just be careful if this command is run before the
buffer has completed loading, as you could be in the middle of a search
instead of the end.

AFAIK, with the "asynchronous" buffer loading, there's no guarantee that
point-max is the end of the search until the other thread has exited.

Again, my lisp-fu is very poor, but just a concern I see.

-Mark


Thread: