Re: [PATCH 2/2] Silence buildbot warnings about unused results

Subject: Re: [PATCH 2/2] Silence buildbot warnings about unused results

Date: Thu, 19 Jan 2012 07:23:21 +0000

To: Austin Clements, notmuch@notmuchmail.org

Cc:

On Wed, 18 Jan 2012 19:40:11 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> +    /* See handle_sigint in notmuch-new.c for the justification for
> +     * ignoring write's result. */
> +    IGNORE_RESULT (write (2, msg, sizeof(msg)-1));

Just include the comment in both places. Someone will work over the code
in notmuch-new.c and we'll lose it.

Then, +1.

part-000.sig (application/pgp-signature)

Previous message (by thread): Re: [PATCH v3 2/2] Silence buildbot warnings about unused results

Thread:

Austin Clements—[PATCH 0/2] Fix or silence "unused result" warnings [inbox, unread]
- Austin Clements—[PATCH 1/2] show: Handle read and write errors [inbox, notmuch::obsolete, notmuch::patch, unread]
- Austin Clements—[PATCH 2/2] Silence buildbot warnings about unused results [inbox, notmuch::obsolete, notmuch::patch, unread]
  - David Edmondson—Re: [PATCH 2/2] Silence buildbot warnings about unused results [inbox, notmuch::review, signed, unread]
    - Austin Clements—Re: [PATCH 2/2] Silence buildbot warnings about unused results [inbox, unread]
- Jani Nikula—Re: [PATCH 0/2] Fix or silence "unused result" warnings [inbox, notmuch::review, unread]
- Austin Clements—[PATCH v2 1/2] show: Handle read and write errors [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Austin Clements—[PATCH v2 2/2] Silence buildbot warnings about unused results [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Austin Clements—[PATCH v3 0/2] [inbox, unread]
    - Austin Clements—[PATCH v3 1/2] show: Handle read and write errors [inbox, notmuch::patch, notmuch::pushed, unread]
      - Tomi Ollila—Re: [PATCH v3 1/2] show: Handle read and write errors [inbox, notmuch::review, unread]
      - David Bremner—Re: [PATCH v3 1/2] show: Handle read and write errors [inbox, unread]
    - Austin Clements—[PATCH v3 2/2] Silence buildbot warnings about unused results [inbox, notmuch::patch, notmuch::pushed, unread]
      - Tomi Ollila—Re: [PATCH v3 2/2] Silence buildbot warnings about unused results [inbox, notmuch::review, unread]
      - David Bremner—Re: [PATCH v3 2/2] Silence buildbot warnings about unused results [inbox, unread]