[PATCH 0/2] Fix or silence "unused result" warnings

Subject: [PATCH 0/2] Fix or silence "unused result" warnings

Date: Wed, 18 Jan 2012 19:40:09 -0500

To: notmuch@notmuchmail.org

Cc:

From: Austin Clements

I'm afraid I bikeshedded dme's original patch for this into oblivion
(id:"1324503532-5799-1-git-send-email-dme@dme.org") and we still have
these warnings on the buildbot.  Tomi convinced me that dme was right
and I was wrong, so I'm bringing dme's patch back.

The first patch actually fixes the warning, since the code in show was
wantonly ignoring errors that could have correctness implications.
This write didn't get much attention in the original thread.

The second is a rework of dme's patch to silence the warning for the
remaining writes.  I cleaned up the formatting, simplified the macro
magic a little, and added a comment justifying its use.

• Previous message (by thread): Re: [PATCH v3 2/2] Silence buildbot warnings about unused results

Thread:

• Austin Clements—[PATCH 0/2] Fix or silence "unused result" warnings [inbox, unread]
  • Austin Clements—[PATCH 1/2] show: Handle read and write errors [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Austin Clements—[PATCH 2/2] Silence buildbot warnings about unused results [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—Re: [PATCH 2/2] Silence buildbot warnings about unused results [inbox, notmuch::review, signed, unread]
      • Austin Clements—Re: [PATCH 2/2] Silence buildbot warnings about unused results [inbox, unread]
  • Jani Nikula—Re: [PATCH 0/2] Fix or silence "unused result" warnings [inbox, notmuch::review, unread]
  • Austin Clements—[PATCH v2 1/2] show: Handle read and write errors [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Austin Clements—[PATCH v2 2/2] Silence buildbot warnings about unused results [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Austin Clements—[PATCH v3 0/2] [inbox, unread]
      • Austin Clements—[PATCH v3 1/2] show: Handle read and write errors [inbox, notmuch::patch, notmuch::pushed, unread]
        • Tomi Ollila—Re: [PATCH v3 1/2] show: Handle read and write errors [inbox, notmuch::review, unread]
        • David Bremner—Re: [PATCH v3 1/2] show: Handle read and write errors [inbox, unread]
      • Austin Clements—[PATCH v3 2/2] Silence buildbot warnings about unused results [inbox, notmuch::patch, notmuch::pushed, unread]
        • Tomi Ollila—Re: [PATCH v3 2/2] Silence buildbot warnings about unused results [inbox, notmuch::review, unread]
        • David Bremner—Re: [PATCH v3 2/2] Silence buildbot warnings about unused results [inbox, unread]