Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

Subject: Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

Date: Mon, 23 Jan 2012 08:16:03 +0000

To: Jameson Graef Rollins

Cc: notmuch

From: David Edmondson

On Sun, 22 Jan 2012 13:38:09 -0800, Jameson Graef Rollins <> wrote:
> This patch seems to include multiple distinct changes.  There is a
> change to notmuch-show-insert-part-header, but a seemingly unrelated
> change to the insertion of signed/encrypted part buttons.  They should
> be in separate patches.

I can separate them.

> I'm also not sure I understand why the proposed changes to the
> signed/encrypted button insertion functions are necessary or desired.
> Was there a problem with the logic as it was?  What is gained by
> having one function filled with special casing to handle two things,
> rather than having two distinct functions?

There was no problem with the logic. The code in the two functions was
almost identical, so I'd like to make any future changes in just one

You didn't actually answer my question - is the logic in the new
function correct?

> Finally, this patch throws out all the changes from the previous patch,
> making the previous patch superfluous.

I'll merge the first patch into the later (and presumably get accused of
submitting patches which include multiple distinct changes :-)).
part-000.sig (application/pgp-signature)