Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

Subject: Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

Date: Sun, 22 Jan 2012 13:38:09 -0800

To: David Edmondson,


From: Jameson Graef Rollins

On Fri, 20 Jan 2012 09:43:31 +0000, David Edmondson <> wrote:
> Instead, allow the caller to specify some parameters for the
> button. Rework `notmuch-show-insert-part-multipart/signed' and
> `notmuch-show-insert-part-multipart/encrypted' accordingly, moving
> most of the code into a common
> `notmuch-show-insert-part-multipart/signed-or-encrypted' to reduce
> duplication.

Hi, David.  A couple of issues with this patch:

This patch seems to include multiple distinct changes.  There is a
change to notmuch-show-insert-part-header, but a seemingly unrelated
change to the insertion of signed/encrypted part buttons.  They should
be in separate patches.

I'm also not sure I understand why the proposed changes to the
signed/encrypted button insertion functions are necessary or desired.
Was there a problem with the logic as it was?  What is gained by having
one function filled with special casing to handle two things, rather
than having two distinct functions?

Finally, this patch throws out all the changes from the previous patch,
making the previous patch superfluous.

part-000.sig (application/pgp-signature)