On Tue, 24 Jan 2012 12:53:38 +0000, David Edmondson <email@example.com> wrote: > Instead, allow the caller to specify some parameters for the > button. Rework `notmuch-show-insert-part-multipart/signed' and > `notmuch-show-insert-part-multipart/encrypted' accordingly. Hi, David. I was thinking about this, and it seems to me that returning the button itself is useful. I can imagine in the future that it might be useful to be able to modify the button after you've created. Maybe it's inconvenient to specify all button parameters at creation time. Is there a reason it's really necessary to make this change? Can't callers just ignore the returned button if they don't care about it further? I can see that maybe it's nice to be able to specify parameters at creation time, but I'm not sure why that requires throwing out the returned object as well. jamie.