Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

Subject: Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

Date: Tue, 24 Jan 2012 10:46:57 -0800

To: David Edmondson, notmuch@notmuchmail.org

Cc:

From: Jameson Graef Rollins

On Tue, 24 Jan 2012 12:53:38 +0000, David Edmondson <dme@dme.org> wrote:
> Instead, allow the caller to specify some parameters for the
> button. Rework `notmuch-show-insert-part-multipart/signed' and
> `notmuch-show-insert-part-multipart/encrypted' accordingly.

Hi, David.  I was thinking about this, and it seems to me that returning
the button itself is useful.  I can imagine in the future that it might
be useful to be able to modify the button after you've created.  Maybe
it's inconvenient to specify all button parameters at creation time.

Is there a reason it's really necessary to make this change?  Can't
callers just ignore the returned button if they don't care about it
further?  I can see that maybe it's nice to be able to specify
parameters at creation time, but I'm not sure why that requires throwing
out the returned object as well.

jamie.

• Previous message (by thread): Re: [PATCH v2] emacs: Add more processing of displayed headers.

Thread:

• David Edmondson—[PATCH 1/3] emacs: Tidy `notmuch-show-insert-part-header'. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Edmondson—[PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jameson Graef Rollins—Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, notmuch::review, signed, unread]
    • Jameson Graef Rollins—Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, notmuch::review, signed, unread]
      • David Edmondson—Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, signed, unread]
        • Jameson Graef Rollins—Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, signed, unread]
          • David Edmondson—Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, signed, unread]
            • David Edmondson—[PATCH 1/3 v2] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, notmuch::obsolete, notmuch::patch, unread]
              • David Edmondson—[PATCH 2/3 v2] emacs: Optionally hide some part headers. [inbox, notmuch::obsolete, notmuch::patch, unread]
              • David Edmondson—[PATCH 3/3 v2] emacs: Don't insert a part header if it's the first part and text/*. [inbox, notmuch::obsolete, notmuch::patch, unread]
              • David Edmondson—Re: [PATCH 1/3 v2] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, signed, unread]
  • David Edmondson—[PATCH 3/3] emacs: Optionally hide some part headers. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Edmondson—optional hiding of some part headers v3 [inbox, unread]
    • David Edmondson—[PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Jameson Graef Rollins—Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, signed, unread]
        • David Edmondson—Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, signed, unread]
          • Jameson Graef Rollins—Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, signed, unread]
            • David Edmondson—Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, signed, unread]
      • Tomi Ollila—Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, notmuch::review, unread]
    • David Edmondson—[PATCH 2/3] emacs: Optionally hide some part headers. [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Tomi Ollila—Re: [PATCH 2/3] emacs: Optionally hide some part headers. [inbox, notmuch::review, unread]
    • David Edmondson—[PATCH 3/3] emacs: Don't insert a part header if it's the first part and text/*. [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Tomi Ollila—Re: [PATCH 3/3] emacs: Don't insert a part header if it's the first part and text/*. [inbox, notmuch::review, unread]
  • David Edmondson—[PATCH v3 0/3] part header code tidying and options [inbox, unread]
    • David Edmondson—[PATCH v2] emacs: Add more processing of displayed headers. [inbox, notmuch::emacs, notmuch::feature, notmuch::moreinfo, notmuch::patch, unread]
      • David Bremner—Re: [PATCH v2] emacs: Add more processing of displayed headers. [inbox, unread]
        • David Edmondson—Re: [PATCH v2] emacs: Add more processing of displayed headers. [inbox, signed, unread]
      • Ethan Glasser-Camp—Re: [PATCH v2] emacs: Add more processing of displayed headers. [inbox, notmuch::review, unread]
    • David Edmondson—[PATCH v3 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, notmuch::moreinfo, notmuch::patch, notmuch::stale, unread]
    • David Edmondson—[PATCH v3 2/3] emacs: Optionally hide some part headers. [inbox, notmuch::moreinfo, notmuch::patch, notmuch::stale, unread]
      • Mark Walters—Re: [PATCH v3 2/3] emacs: Optionally hide some part headers. [inbox, unread]
    • David Edmondson—[PATCH v3 3/3] emacs: Don't insert a part header if it's the first part and text/*. [inbox, notmuch::moreinfo, notmuch::patch, notmuch::stale, unread]
      • Mark Walters—Re: [PATCH v3 3/3] emacs: Don't insert a part header if it's the first part and text/*. [inbox, unread]
        • Mark Walters—Re: [PATCH v3 3/3] emacs: Don't insert a part header if it's the first part and text/*. [inbox, unread]