Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

Subject: Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

Date: Fri, 20 Jan 2012 12:20:20 -0800

To: David Edmondson,


From: Jameson Graef Rollins

On Fri, 20 Jan 2012 09:43:31 +0000, David Edmondson <> wrote:
> The buttons inserted for encrypted parts are slightly different now -
> previously the logic was that if a part was encrypted it would have
> the signature status inserted only if the encryption status was
> specified. Now the signature status will be inserted even without
> encryption status. My reading of the documentation says that this is
> correct, but I'm no expert. Comments?

I need some more time to review this patch, but I don't think this is
correct.  The signature status of encrypted messages (or even if the
message was signed at all) comes from the decryption process.  They're
not independent.  If the decryption fails it's unknown if there was a
signature or not.

I need to look closer at this, though.  Hopefully this weekend.

part-000.sig (application/pgp-signature)