Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

Subject: Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

Date: Fri, 20 Jan 2012 12:20:20 -0800

To: David Edmondson, notmuch@notmuchmail.org

Cc:

On Fri, 20 Jan 2012 09:43:31 +0000, David Edmondson <dme@dme.org> wrote:
> The buttons inserted for encrypted parts are slightly different now -
> previously the logic was that if a part was encrypted it would have
> the signature status inserted only if the encryption status was
> specified. Now the signature status will be inserted even without
> encryption status. My reading of the documentation says that this is
> correct, but I'm no expert. Comments?

I need some more time to review this patch, but I don't think this is
correct.  The signature status of encrypted messages (or even if the
message was signed at all) comes from the decryption process.  They're
not independent.  If the decryption fails it's unknown if there was a
signature or not.

I need to look closer at this, though.  Hopefully this weekend.

jamie.

part-000.sig (application/pgp-signature)

Previous message (by thread): Re: [PATCH v2] emacs: Add more processing of displayed headers.

Thread:

David Edmondson—[PATCH 1/3] emacs: Tidy `notmuch-show-insert-part-header'. [inbox, notmuch::obsolete, notmuch::patch, unread]
- David Edmondson—[PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jameson Graef Rollins—Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, notmuch::review, signed, unread]
  - Jameson Graef Rollins—Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, notmuch::review, signed, unread]
    - David Edmondson—Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, signed, unread]
      - Jameson Graef Rollins—Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, signed, unread]
        David Edmondson—Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, signed, unread]
        David Edmondson—[PATCH 1/3 v2] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, notmuch::obsolete, notmuch::patch, unread]
        David Edmondson—[PATCH 2/3 v2] emacs: Optionally hide some part headers. [inbox, notmuch::obsolete, notmuch::patch, unread]
        David Edmondson—[PATCH 3/3 v2] emacs: Don't insert a part header if it's the first part and text/*. [inbox, notmuch::obsolete, notmuch::patch, unread]
        David Edmondson—Re: [PATCH 1/3 v2] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, signed, unread]
- David Edmondson—[PATCH 3/3] emacs: Optionally hide some part headers. [inbox, notmuch::obsolete, notmuch::patch, unread]
- David Edmondson—optional hiding of some part headers v3 [inbox, unread]
  - David Edmondson—[PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, notmuch::obsolete, notmuch::patch, unread]
    - Jameson Graef Rollins—Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, signed, unread]
      - David Edmondson—Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, signed, unread]
        Jameson Graef Rollins—Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, signed, unread]
        David Edmondson—Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, signed, unread]
    - Tomi Ollila—Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, notmuch::review, unread]
  - David Edmondson—[PATCH 2/3] emacs: Optionally hide some part headers. [inbox, notmuch::obsolete, notmuch::patch, unread]
    - Tomi Ollila—Re: [PATCH 2/3] emacs: Optionally hide some part headers. [inbox, notmuch::review, unread]
  - David Edmondson—[PATCH 3/3] emacs: Don't insert a part header if it's the first part and text/*. [inbox, notmuch::obsolete, notmuch::patch, unread]
    - Tomi Ollila—Re: [PATCH 3/3] emacs: Don't insert a part header if it's the first part and text/*. [inbox, notmuch::review, unread]
- David Edmondson—[PATCH v3 0/3] part header code tidying and options [inbox, unread]
  - David Edmondson—[PATCH v2] emacs: Add more processing of displayed headers. [inbox, notmuch::emacs, notmuch::feature, notmuch::moreinfo, notmuch::patch, unread]
    - David Bremner—Re: [PATCH v2] emacs: Add more processing of displayed headers. [inbox, unread]
      - David Edmondson—Re: [PATCH v2] emacs: Add more processing of displayed headers. [inbox, signed, unread]
    - Ethan Glasser-Camp—Re: [PATCH v2] emacs: Add more processing of displayed headers. [inbox, notmuch::review, unread]
  - David Edmondson—[PATCH v3 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. [inbox, notmuch::moreinfo, notmuch::patch, notmuch::stale, unread]
  - David Edmondson—[PATCH v3 2/3] emacs: Optionally hide some part headers. [inbox, notmuch::moreinfo, notmuch::patch, notmuch::stale, unread]
    - Mark Walters—Re: [PATCH v3 2/3] emacs: Optionally hide some part headers. [inbox, unread]
  - David Edmondson—[PATCH v3 3/3] emacs: Don't insert a part header if it's the first part and text/*. [inbox, notmuch::moreinfo, notmuch::patch, notmuch::stale, unread]
    - Mark Walters—Re: [PATCH v3 3/3] emacs: Don't insert a part header if it's the first part and text/*. [inbox, unread]
      - Mark Walters—Re: [PATCH v3 3/3] emacs: Don't insert a part header if it's the first part and text/*. [inbox, unread]