The patch works fine for me. Ian, though I could not test whether result='' matters or not, cause 'notmuch get' looks to always return a string. It also fixes id:CAHc2pO19AZabAiJhdfQR1rL5t0GufLAq5cKb_7w-Z8y+JXT5+g@mail.gmail.com On Fri, Oct 3, 2014 at 10:54 AM, David Bremner <david@tethera.net> wrote: > Ian Main <imain@stemwinder.org> writes: > >> This patch switches from reading .notmuch-config directly to using >> the CLI the same way that emacs does it. It actually uses less code >> and is probably less error prone. >> >> Ian > > The general approach seems sane; it seems quite brittle to read the > config file directly. I notice there is not really any error handling; > OTOH, as far as I can read Ruby, there is not any in the previous > version either. Technically, this does add a dependency of the vim > client on the CLI that did not exist before. Personally I don't find > this onerous (even notmuch-vim users need "notmuch new", except in > rather unusual circumstances.). > > I'd like feedback/testing from actual vim interface users before > merging. > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch -- С уважением, Сергей Шиловский Sergei Shilovsky