Re: [PATCH 1/7] Split notmuch_database_close into two functions

Subject: Re: [PATCH 1/7] Split notmuch_database_close into two functions

Date: Sun, 22 Apr 2012 14:06:58 -0400

To: Justus Winter, notmuch@notmuchmail.org

Cc:

From: Austin Clements


On Sun, 22 Apr 2012, Justus Winter <4winter@informatik.uni-hamburg.de> wrote:
> Formerly notmuch_database_close closed the xapian database and
> destroyed the talloc structure associated with the notmuch database
> object. Split notmuch_database_close into notmuch_database_close and
> notmuch_database_destroy.
>
> This makes it possible for long running programs to close the xapian
> database and thus release the lock associated with it without
> destroying the data structures obtained from it.
>
> This also makes the api more consistent since every other data
> structure has a destructor function.
>
> Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>

Other than my comments comment, this series LGTM.  I think adding those
comments should also address Felipe's question.

Thread: