Re: [PATCH 7/7] python: wrap and use notmuch_database_destroy as destructor

Subject: Re: [PATCH 7/7] python: wrap and use notmuch_database_destroy as destructor

Date: Fri, 20 Apr 2012 15:10:04 +0200

To: Austin Clements, Justus Winter

Cc: notmuch@notmuchmail.org

From: Sebastian Spaeth

Austin Clements <amdragon@MIT.EDU> writes:
> (I think it also doesn't make sense to expose notmuch_database_destroy
> as a general, public method since it will free all of the other C
> objects out from under the bindings, resulting in exactly the double
> free-type crashes that you're trying to avoid.  It appears that none
> of the other Python classes have a destroy method.)

Agreed, that sounds right to me.

Sebastian

• Previous message (by thread): Re: [PATCH 1/7] Split notmuch_database_close into two functions

Thread:

• Justus Winter—[RFC] Split notmuch_database_close into two functions [inbox, unread]
  • Justus Winter—[PATCH 1/7] Split notmuch_database_close into two functions [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Mark Walters—Re: [PATCH 1/7] Split notmuch_database_close into two functions [inbox, unread]
      • David Bremner—Re: [PATCH 1/7] Split notmuch_database_close into two functions [inbox, unread]
      • Justus Winter—Re: [PATCH 1/7] Split notmuch_database_close into two functions [inbox, unread]
        • Mark Walters—Re: [PATCH 1/7] Split notmuch_database_close into two functions [inbox, unread]
  • Justus Winter—[PATCH 2/7] NEWS: Document the notmuch_database_close split [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Justus Winter—[PATCH 3/7] Use notmuch_database_destroy instead of notmuch_database_close [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Justus Winter—[PATCH 4/7] Use notmuch_database_destroy instead of notmuch_database_close [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Justus Winter—[PATCH 5/7] go: Use notmuch_database_destroy instead of notmuch_database_close [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Justus Winter—[PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Justus Winter—[PATCH 7/7] python: wrap and use notmuch_database_destroy as destructor [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Austin Clements—Re: [PATCH 7/7] python: wrap and use notmuch_database_destroy as destructor [inbox, notmuch::review, unread]
      • Sebastian Spaeth—Re: [PATCH 7/7] python: wrap and use notmuch_database_destroy as destructor [inbox, signed, unread]
      • Justus Winter—Re: [PATCH 7/7] python: wrap and use notmuch_database_destroy as destructor [inbox, unread]
        • Justus Winter—[PATCH 1/7] Split notmuch_database_close into two functions [inbox, notmuch::obsolete, notmuch::patch, unread]
          • Justus Winter—[PATCH 2/7] NEWS: Document the notmuch_database_close split [inbox, notmuch::patch, notmuch::pushed, unread]
            • Felipe Contreras—Re: [PATCH 2/7] NEWS: Document the notmuch_database_close split [inbox, unread]
          • Justus Winter—[PATCH 3/7] Use notmuch_database_destroy instead of notmuch_database_close [inbox, notmuch::patch, notmuch::pushed, unread]
          • Justus Winter—[PATCH 4/7] Use notmuch_database_destroy instead of notmuch_database_close [inbox, notmuch::patch, notmuch::pushed, unread]
          • Justus Winter—[PATCH 5/7] go: Use notmuch_database_destroy instead of notmuch_database_close [inbox, notmuch::patch, notmuch::pushed, unread]
          • Justus Winter—[PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close [inbox, notmuch::patch, notmuch::pushed, unread]
            • Felipe Contreras—Re: [PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close [inbox, unread]
              • Justus Winter—Re: [PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close [inbox, unread]
                • Austin Clements—Re: [PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close [inbox, unread]
          • Justus Winter—[PATCH 7/7] python: wrap and use notmuch_database_destroy as destructor [inbox, notmuch::patch, notmuch::pushed, unread]
          • Austin Clements—Re: [PATCH 1/7] Split notmuch_database_close into two functions [inbox, notmuch::review, unread]
            • Justus Winter—[PATCH 1/7] Split notmuch_database_close into two functions [inbox, notmuch::patch, notmuch::pushed, unread]
              • Austin Clements—Re: [PATCH 1/7] Split notmuch_database_close into two functions [inbox, notmuch::review, unread]
              • David Bremner—Re: [PATCH 1/7] Split notmuch_database_close into two functions [inbox, unread]
          • Austin Clements—Re: [PATCH 1/7] Split notmuch_database_close into two functions [inbox, unread]
  • Patrick Totzke—Re: [RFC] Split notmuch_database_close into two functions [inbox, unread]
  • Tomi Ollila—Re: [RFC] Split notmuch_database_close into two functions [inbox, unread]
    • Justus Winter—Re: [RFC] Split notmuch_database_close into two functions [inbox, unread]
      • Justus Winter—[PATCH 1/7] Split notmuch_database_close into two functions [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Austin Clements—Re: [RFC] Split notmuch_database_close into two functions [inbox, unread]
    • Justus Winter—Re: [RFC] Split notmuch_database_close into two functions [inbox, unread]
      • Austin Clements—Re: [RFC] Split notmuch_database_close into two functions [inbox, notmuch::review, unread]
        • Justus Winter—Re: [RFC] Split notmuch_database_close into two functions [inbox, unread]
        • Justus Winter—Re: [RFC] Split notmuch_database_close into two functions [inbox, unread]
          • Tomi Ollila—Re: [RFC] Split notmuch_database_close into two functions [inbox, unread]
        • Mark Walters—Re: [RFC] Split notmuch_database_close into two functions [inbox, unread]
          • Austin Clements—Re: [RFC] Split notmuch_database_close into two functions [inbox, unread]