Re: [PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database

Re: [PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close

Subject: Re: [PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close

Date: Mon, 23 Apr 2012 14:49:46 +0200

Quoting Felipe Contreras (2012-04-23 14:36:33)
> I don't think this is the right approach. If database_destroy truly
> destroys the object, then we would want to do it only at garbage
> collection, when it's not accessible any more. What if I want to
> re-use the database from the Ruby code?
> 
> This would probably be better:
> 
>[...]

You're probably right, I don't know the ruby bindings at all, I just
wanted to preserve the old behavior. You are welcome to refine the
ruby bindings later (or maintain them, I *believe* they are
unmaintained, the last change was back in october 2011), but let's get
this patch series in first.

Cheers,
Justus

Previous message (by thread): Re: [PATCH 1/7] Split notmuch_database_close into two functions

Thread:

Justus Winter—[RFC] Split notmuch_database_close into two functions [inbox, unread]
- Justus Winter—[PATCH 1/7] Split notmuch_database_close into two functions [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Mark Walters—Re: [PATCH 1/7] Split notmuch_database_close into two functions [inbox, unread]
    - David Bremner—Re: [PATCH 1/7] Split notmuch_database_close into two functions [inbox, unread]
    - Justus Winter—Re: [PATCH 1/7] Split notmuch_database_close into two functions [inbox, unread]
      - Mark Walters—Re: [PATCH 1/7] Split notmuch_database_close into two functions [inbox, unread]
- Justus Winter—[PATCH 2/7] NEWS: Document the notmuch_database_close split [inbox, notmuch::obsolete, notmuch::patch, unread]
- Justus Winter—[PATCH 3/7] Use notmuch_database_destroy instead of notmuch_database_close [inbox, notmuch::obsolete, notmuch::patch, unread]
- Justus Winter—[PATCH 4/7] Use notmuch_database_destroy instead of notmuch_database_close [inbox, notmuch::obsolete, notmuch::patch, unread]
- Justus Winter—[PATCH 5/7] go: Use notmuch_database_destroy instead of notmuch_database_close [inbox, notmuch::obsolete, notmuch::patch, unread]
- Justus Winter—[PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close [inbox, notmuch::obsolete, notmuch::patch, unread]
- Justus Winter—[PATCH 7/7] python: wrap and use notmuch_database_destroy as destructor [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Austin Clements—Re: [PATCH 7/7] python: wrap and use notmuch_database_destroy as destructor [inbox, notmuch::review, unread]
    - Sebastian Spaeth—Re: [PATCH 7/7] python: wrap and use notmuch_database_destroy as destructor [inbox, signed, unread]
    - Justus Winter—Re: [PATCH 7/7] python: wrap and use notmuch_database_destroy as destructor [inbox, unread]
      - Justus Winter—[PATCH 1/7] Split notmuch_database_close into two functions [inbox, notmuch::obsolete, notmuch::patch, unread]
        Justus Winter—[PATCH 2/7] NEWS: Document the notmuch_database_close split [inbox, notmuch::patch, notmuch::pushed, unread]
        Felipe Contreras—Re: [PATCH 2/7] NEWS: Document the notmuch_database_close split [inbox, unread]
        Justus Winter—[PATCH 3/7] Use notmuch_database_destroy instead of notmuch_database_close [inbox, notmuch::patch, notmuch::pushed, unread]
        Justus Winter—[PATCH 4/7] Use notmuch_database_destroy instead of notmuch_database_close [inbox, notmuch::patch, notmuch::pushed, unread]
        Justus Winter—[PATCH 5/7] go: Use notmuch_database_destroy instead of notmuch_database_close [inbox, notmuch::patch, notmuch::pushed, unread]
        Justus Winter—[PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close [inbox, notmuch::patch, notmuch::pushed, unread]
        Felipe Contreras—Re: [PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close [inbox, unread]
        Justus Winter—Re: [PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close [inbox, unread]
        Austin Clements—Re: [PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close [inbox, unread]
        Justus Winter—[PATCH 7/7] python: wrap and use notmuch_database_destroy as destructor [inbox, notmuch::patch, notmuch::pushed, unread]
        Austin Clements—Re: [PATCH 1/7] Split notmuch_database_close into two functions [inbox, notmuch::review, unread]
        Justus Winter—[PATCH 1/7] Split notmuch_database_close into two functions [inbox, notmuch::patch, notmuch::pushed, unread]
        Austin Clements—Re: [PATCH 1/7] Split notmuch_database_close into two functions [inbox, notmuch::review, unread]
        David Bremner—Re: [PATCH 1/7] Split notmuch_database_close into two functions [inbox, unread]
        Austin Clements—Re: [PATCH 1/7] Split notmuch_database_close into two functions [inbox, unread]
- Patrick Totzke—Re: [RFC] Split notmuch_database_close into two functions [inbox, unread]
- Tomi Ollila—Re: [RFC] Split notmuch_database_close into two functions [inbox, unread]
  - Justus Winter—Re: [RFC] Split notmuch_database_close into two functions [inbox, unread]
    - Justus Winter—[PATCH 1/7] Split notmuch_database_close into two functions [inbox, notmuch::obsolete, notmuch::patch, unread]
- Austin Clements—Re: [RFC] Split notmuch_database_close into two functions [inbox, unread]
  - Justus Winter—Re: [RFC] Split notmuch_database_close into two functions [inbox, unread]
    - Austin Clements—Re: [RFC] Split notmuch_database_close into two functions [inbox, notmuch::review, unread]
      - Justus Winter—Re: [RFC] Split notmuch_database_close into two functions [inbox, unread]
      - Justus Winter—Re: [RFC] Split notmuch_database_close into two functions [inbox, unread]
        Tomi Ollila—Re: [RFC] Split notmuch_database_close into two functions [inbox, unread]
      - Mark Walters—Re: [RFC] Split notmuch_database_close into two functions [inbox, unread]
        Austin Clements—Re: [RFC] Split notmuch_database_close into two functions [inbox, unread]