Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes: > This prepares us for using the crypto object in both the library and > the client. > > i've prefixed notmuch_crypto with _ to indicate that while this can be > built into the library when needed, it's not something to be exported > or used externally. [...] snip > diff --git a/mime-node.c b/mime-node.c > index e96e663..a8f5670 100644 > --- a/mime-node.c > +++ b/mime-node.c > @@ -33,7 +33,7 @@ typedef struct mime_node_context { > GMimeMessage *mime_message; > > /* Context provided by the caller. */ > - notmuch_crypto_t *crypto; > + _notmuch_crypto_t *crypto; > } mime_node_context_t; is this maybe search and replace gone wild? or did you mean to rename the type as well as the functions? > static void > node_verify (mime_node_t *node, GMimeObject *part, > - notmuch_crypto_context_t *cryptoctx) > + GMimeCryptoContext *cryptoctx) > { This change of parameter type seems significant. Does it deserve a comment in the commit message?