Re: [PATCH v3 15/16] added notmuch_message_reindex

Subject: Re: [PATCH v3 15/16] added notmuch_message_reindex

Date: Tue, 09 Feb 2016 20:01:43 -0500

To: Jameson Graef Rollins, Notmuch Mail

Cc:

From: Daniel Kahn Gillmor

On Tue 2016-02-09 19:41:01 -0500, Jameson Graef Rollins wrote:
> On Sun, Jan 31 2016, Daniel Kahn Gillmor <dkg@fifthhorseman.net> wrote:
>> This new function asks the database to reindex a given message, using
>> the supplied indexopts.
>>
>> This can be used, for example, to index the cleartext of an encrypted
>> message.
>
> I just wanted to mention that I think there's a problem with the reindex
> functionality introduced in this patch (or in 16/16).  It looks like
> this function irrevocably busts apart threads.  dkg and I are
> investigating.

it doesn't appear to be irrevocable to me, but it is definitely doing
something weird with threading.

we have a three message thread tagged "weird-thread":

  ( a ← b ← c )

if i do:

   notmuch reindex id:a

then we see two threads:

  ( a ) , ( b ← c )

if i then do:

   notmuch reindex id:b

then i see two threads:


   ( a ← b ) ,  ( c )


and if i then do:

   notmuch reindex id:c

then i see one thread again:

   ( a ← b ← c )

but interestingly, reindexing all the messages together by search tearm

  notmuch reindex tag:weird-thread

doesn't affect the threading.


i think this is happening without regard to --try-decrypt, fwiw.

  --dkg

Thread: