Re: [PATCH v3 11/16] add --try-decrypt to notmuch insert

Subject: Re: [PATCH v3 11/16] add --try-decrypt to notmuch insert

Date: Sat, 27 Feb 2016 11:55:15 -0400

To: Daniel Kahn Gillmor, Notmuch Mail

Cc:

From: David Bremner


Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
> +    if (try_decrypt) {
> +	const char* gpg_path = notmuch_config_get_crypto_gpg_path (config);
> +	status = notmuch_indexopts_set_gpg_path (indexopts, gpg_path);
> +	if (status)
> +	    fprintf (stderr, "Warning: failed to set database gpg_path to '%s' (%s)\n",
> +		     gpg_path ? gpg_path : "(NULL)",
> +		     notmuch_status_to_string (status));
> +    }

Should this really be non-fatal event? I agree that the indexing can
carry on, but are there reasons for this to fail that don't indicate
something has gone really wrong?

d

Thread: