Re: [PATCH v3 15/16] added notmuch_message_reindex

Subject: Re: [PATCH v3 15/16] added notmuch_message_reindex

Date: Tue, 09 Feb 2016 16:41:01 -0800

To: Daniel Kahn Gillmor, Notmuch Mail

Cc:

From: Jameson Graef Rollins

On Sun, Jan 31 2016, Daniel Kahn Gillmor <dkg@fifthhorseman.net> wrote:
> This new function asks the database to reindex a given message, using
> the supplied indexopts.
>
> This can be used, for example, to index the cleartext of an encrypted
> message.

I just wanted to mention that I think there's a problem with the reindex
functionality introduced in this patch (or in 16/16).  It looks like
this function irrevocably busts apart threads.  dkg and I are
investigating.

jamie.

• Previous message (by thread): Re: [PATCH v3 16/16] add "notmuch reindex" subcommand

Thread:

• Daniel Kahn Gillmor—Allow indexing cleartext of encrypted messages (v3) [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v3 01/16] add util/search-path.{c, h} to test for executables in $PATH [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v3 01/16] add util/search-path.{c, h} to test for executables in $PATH [inbox, unread]
      • Daniel Kahn Gillmor—[PATCH v4] add util/search-path.{c, h} to test for executables in $PATH [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v3 02/16] Move crypto.c into libutil [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v3 02/16] Move crypto.c into libutil [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH v3 02/16] Move crypto.c into libutil [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v3 03/16] make shared crypto code behave library-like [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v3 03/16] make shared crypto code behave library-like [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH v3 03/16] make shared crypto code behave library-like [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v3 04/16] Provide _notmuch_crypto_{set,get}_gpg_path [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v3 04/16] Provide _notmuch_crypto_{set,get}_gpg_path [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH v3 04/16] Provide _notmuch_crypto_{set,get}_gpg_path [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v3 05/16] Use a blank _notmuch_crypto to choose the default gpg_path [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v3 05/16] Use a blank _notmuch_crypto to choose the default gpg_path [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH v3 05/16] Use a blank _notmuch_crypto to choose the default gpg_path [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v3 06/16] Prefer gpg2 in the test suite if available [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v3 06/16] Prefer gpg2 in the test suite if available [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH v3 06/16] Prefer gpg2 in the test suite if available [inbox, unread]
        • David Bremner—Re: [PATCH v3 06/16] Prefer gpg2 in the test suite if available [inbox, unread]
        • Tomi Ollila—Re: [PATCH v3 06/16] Prefer gpg2 in the test suite if available [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v3 07/16] create a notmuch_indexopts_t index options object [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v3 07/16] create a notmuch_indexopts_t index options object [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v3 08/16] reorganize indexing of multipart/signed and multipart/encrypted [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v3 08/16] reorganize indexing of multipart/signed and multipart/encrypted [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v3 09/16] index encrypted parts when asked. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v3 09/16] index encrypted parts when asked. [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v3 10/16] Add n_d_add_message_with_indexopts (extension of n_d_add_message) [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v3 11/16] add --try-decrypt to notmuch insert [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v3 11/16] add --try-decrypt to notmuch insert [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v3 12/16] add --try-decrypt to notmuch new [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v3 13/16] add indexopts to notmuch python bindings. [inbox, notmuch::obsolete, notmuch::patch, notmuch::python, unread]
    • David Bremner—Re: [PATCH v3 13/16] add indexopts to notmuch python bindings. [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v3 14/16] test indexing cleartext version of delivered messages. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v3 15/16] added notmuch_message_reindex [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jameson Graef Rollins—Re: [PATCH v3 15/16] added notmuch_message_reindex [inbox, signed, unread]
      • Daniel Kahn Gillmor—Re: [PATCH v3 15/16] added notmuch_message_reindex [inbox, unread]
        • Daniel Kahn Gillmor—Re: [PATCH v3 15/16] added notmuch_message_reindex [attachment, inbox, signed, unread]
          • David Bremner—Re: [PATCH v3 15/16] added notmuch_message_reindex [inbox, unread]
    • David Bremner—Re: [PATCH v3 15/16] added notmuch_message_reindex [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v3 16/16] add "notmuch reindex" subcommand [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v3 16/16] add "notmuch reindex" subcommand [inbox, unread]
  • Tomi Ollila—Re: Allow indexing cleartext of encrypted messages (v3) [inbox, unread]
  • Jameson Graef Rollins—Re: Allow indexing cleartext of encrypted messages (v3) [inbox, signed, unread]