Re: [PATCH v6] emacs: Let the user choose where to compose new mails

Subject: Re: [PATCH v6] emacs: Let the user choose where to compose new mails

Date: Sat, 05 May 2012 16:20:59 -0700

To: Thomas Jost, notmuch@notmuchmail.org

Cc:

From: Jameson Graef Rollins


On Fri, May 04 2012, Thomas Jost <schnouki@schnouki.net> wrote:
> Here it is again, with a warning in the customize message that only
> appears in Emacs 23. The indentation is a little bit of a mess but
> that's needed for the docstring to look good :)

Great!  That's a nice trick, Thomas.  Thanks.  This should definitely
address David's concerns.

> (If you want I can remove the test and also display the Emacs 23
> warning in Emacs 24.)

I think the included solution is perfect.

> Does it look good to you? I'm not comfortable with writing docs in
> English, so feel free to rephrase it if needed.

Yes, it is good.  It reads well and includes all the relevant
information.

> I also moved notmuch-mua-compose-in to the 'notmuch-send group, just
> as other notmuch-mua-* variables.

Perfect.

I have reviewed and tested this updated version of the patch and
everything looks and works great.  Thank you so much for topping this
off, Thomas.

jamie.
part-000.sig (application/pgp-signature)

Thread: