Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps

Subject: Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps

Date: Sun, 25 May 2014 12:17:46 +0300

To: Felipe Contreras, Felipe Contreras, notmuch@notmuchmail.org

Cc: Ali Polatel

From: Jani Nikula

On Sun, 25 May 2014, Felipe Contreras <felipe.contreras@gmail.com> wrote:
> Jani Nikula wrote:
>> On Fri, 23 May 2014, Felipe Contreras <felipe.contreras@gmail.com> wrote:
>> > They don't affect the global build.
>> 
>> They do.
>
> They don't.

Your patch, your commit message, please explain *why* you think they
wouldn't or shouldn't affect the global build. Just to mention one
thing, why someone modifying cflags in sub makefiles shouldn't cause
rebuild?


BR,
Jani.

• Previous message (by thread): Re: [PATCH 2/3] build: add support to build Ruby bindings

Thread:

• Felipe Contreras—[PATCH 0/3] Build and test Ruby bindings [inbox, unread]
  • Felipe Contreras—[PATCH 1/3] build: don't add sub Makefiles to the global deps [inbox, notmuch::moreinfo, notmuch::patch, unread]
    • Jani Nikula—Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps [inbox, unread]
      • Felipe Contreras—Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps [inbox, unread]
        • Jani Nikula—Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps [inbox, unread]
          • Felipe Contreras—Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps [inbox, unread]
            • Jani Nikula—Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps [inbox, unread]
  • Felipe Contreras—[PATCH 2/3] build: add support to build Ruby bindings [inbox, notmuch::moreinfo, notmuch::patch, unread]
    • Wael Nasreddine—Re: [PATCH 2/3] build: add support to build Ruby bindings [inbox, signed, unread]
    • David Bremner—Re: [PATCH 2/3] build: add support to build Ruby bindings [inbox, unread]
  • Felipe Contreras—[PATCH 3/3] test: add tests for Ruby bindings [inbox, notmuch::moreinfo, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 3/3] test: add tests for Ruby bindings [inbox, unread]