Re: [PATCH 2/3] build: add support to build Ruby bindings

Subject: Re: [PATCH 2/3] build: add support to build Ruby bindings

Date: Sun, 13 Jul 2014 11:28:41 -0300

To: Felipe Contreras, notmuch@notmuchmail.org

Cc: Ali Polatel

From: David Bremner

Felipe Contreras <felipe.contreras@gmail.com> writes:
> +
> +$(dir)/notmuch.so: | $(dir)/Makefile lib/libnotmuch.so
> +	@$(MAKE) -C $(dir) notmuch.so

- since this is the only place (afaik) in the notmuch codebase that
order only prereqs are used, their use probably deserves some comment.

- can you explain why you depend on $(dir)/Makefile here?

d

• Previous message (by thread): Re: [PATCH 2/3] build: add support to build Ruby bindings

Thread:

• Felipe Contreras—[PATCH 0/3] Build and test Ruby bindings [inbox, unread]
  • Felipe Contreras—[PATCH 1/3] build: don't add sub Makefiles to the global deps [inbox, notmuch::moreinfo, notmuch::patch, unread]
    • Jani Nikula—Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps [inbox, unread]
      • Felipe Contreras—Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps [inbox, unread]
        • Jani Nikula—Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps [inbox, unread]
          • Felipe Contreras—Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps [inbox, unread]
            • Jani Nikula—Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps [inbox, unread]
  • Felipe Contreras—[PATCH 2/3] build: add support to build Ruby bindings [inbox, notmuch::moreinfo, notmuch::patch, unread]
    • Wael Nasreddine—Re: [PATCH 2/3] build: add support to build Ruby bindings [inbox, signed, unread]
    • David Bremner—Re: [PATCH 2/3] build: add support to build Ruby bindings [inbox, unread]
  • Felipe Contreras—[PATCH 3/3] test: add tests for Ruby bindings [inbox, notmuch::moreinfo, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 3/3] test: add tests for Ruby bindings [inbox, unread]