Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps

Subject: Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps

Date: Sun, 25 May 2014 20:01:44 +0300

To: Felipe Contreras, Felipe Contreras, Felipe Contreras, notmuch@notmuchmail.org

Cc: Ali Polatel

From: Jani Nikula

On Sun, 25 May 2014, Felipe Contreras <felipe.contreras@gmail.com> wrote:
> Jani Nikula wrote:
>> On Sun, 25 May 2014, Felipe Contreras <felipe.contreras@gmail.com> wrote:
>> > Jani Nikula wrote:
>> >> On Fri, 23 May 2014, Felipe Contreras <felipe.contreras@gmail.com> wrote:
>> >> > They don't affect the global build.
>> >> 
>> >> They do.
>> >
>> > They don't.
>> 
>> Your patch, your commit message, please explain *why* you think they
>> wouldn't or shouldn't affect the global build. Just to mention one
>> thing, why someone modifying cflags in sub makefiles shouldn't cause
>> rebuild?
>
> Go to emacs/Makefile, it's basically a stub, why would any modifications
> there affect the global build? It's not included anywhere.
>
> emacs/Makefile.local is included in the global build, emacs/Makefile is
> not.

Fair enough. And what is the benefit of not depending on them, since
they hardly ever change? I'd rather err on the depending side.

BR,
Jani.

Thread: