Re: [PATCH 3/3] test: add tests for Ruby bindings

Subject: Re: [PATCH 3/3] test: add tests for Ruby bindings

Date: Sun, 13 Jul 2014 10:11:40 -0300

To: Felipe Contreras, notmuch@notmuchmail.org

Cc: Ali Polatel

From: David Bremner


Felipe Contreras <felipe.contreras@gmail.com> writes:

>  2 files changed, 99 insertions(+)
>  create mode 100755 test/T540-ruby.sh
> +# Copyright (c) 2014 Felipe Contreras

Thanks for writing these; lack of tests bindings has been a long time
irritant for me.  Can you put in a brief license statement as well as
the copyright line?  Something like "same as notmuch" or "GPL 3+" is ok
for me.

>  
> +grep -q "WITH_RUBY = 1" ../Makefile.config && test_set_prereq RUBY

This looks a bit fragile. Somewhere in the patch queue is something to
create a config.sh snippet which would help here.

d



Thread: