Re: [PATCH v2 00/36] [emacs] Add outline headings and switch to lexical scope

Subject: Re: [PATCH v2 00/36] [emacs] Add outline headings and switch to lexical scope

Date: Wed, 13 Jan 2021 08:11:27 -0400

To: Jonas Bernoulli, notmuch@notmuchmail.org

Cc:

From: David Bremner

Jonas Bernoulli <jonas@bernoul.li> writes:

> This fixes a minor whitespace bug that Tomi notices in (1).
>
> This also adds for commits, two of them in response to a concern
> raised by Tomi, who didn't "see enough point for requiring subr-x
> just [for string-empty-p]", which I agree with:
>
> 2) Changes how `cl-lib' and `pcase' are required.  I did that first
>    because I want to do it the same way as for `subr-x'.
>
> 3) Require `subr-x', so that we can use it without having to worry
>    whether we have now reached the threshold where it becomes
>    justified to require an additional library.

I pushed applied the first 22 patches to master.

"[PATCH v2 23/36] emacs: various cosmetic improvements" leads to some
test failures. FWIW, I'm using Emacs 27.1 on Debian testing.

T310-emacs: Testing emacs interface
 FAIL   notmuch-fcc-dirs set to a list (with match)
	--- T310-emacs.28.EXPECTED	2021-01-13 12:00:57.901428602 +0000
	+++ T310-emacs.28.OUTPUT	2021-01-13 12:00:57.905428701 +0000
	@@ -1,5 +0,0 @@
	-From: Notmuch Test Suite <test_suite@notmuchmail.org>
	-To: 
	-Subject: 
	-Fcc: /home/bremner/software/upstream/notmuch/test/tmp.T310-emacs/mail/sent-list-match
	---text follows this line--
*ERROR*: Wrong type argument: listp, "sent-list-match"
 FAIL   notmuch-fcc-dirs set to a list (catch-all)
	--- T310-emacs.29.EXPECTED	2021-01-13 12:00:57.933429400 +0000
	+++ T310-emacs.29.OUTPUT	2021-01-13 12:00:57.933429400 +0000
	@@ -1,5 +0,0 @@
	-From: Notmuch Test Suite <test_suite@notmuchmail.org>
	-To: 
	-Subject: 
	-Fcc: /home/bremner/software/upstream/notmuch/test/tmp.T310-emacs/mail/sent-list-catch-all
	---text follows this line--
*ERROR*: Wrong type argument: listp, "failure"
 FAIL   notmuch-fcc-dirs set to a list (no match)
	--- T310-emacs.30.EXPECTED	2021-01-13 12:00:57.953429900 +0000
	+++ T310-emacs.30.OUTPUT	2021-01-13 12:00:57.957430000 +0000
	@@ -1,4 +0,0 @@
	-From: Notmuch Test Suite <test_suite@notmuchmail.org>
	-To: 
	-Subject: 
	---text follows this line--
*ERROR*: Wrong type argument: listp, "failure"
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

• Previous message (by thread): Re: [PATCH v2 36/36] emacs: notmuch-address-expand-name: use the actual initial-input

Thread:

• Jonas Bernoulli—[PATCH 00/32] [emacs] Add outline headings and switch to lexical scope [inbox, unread]
  • Jonas Bernoulli—[PATCH 01/32] emacs: use setq instead of set [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 02/32] emacs: sanitize dedicated widget action/notify functions [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 03/32] emacs: define new notmuch-search-item widget type [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 04/32] emacs: notmuch-start-notmuch: remove backward compatibility code [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 05/32] emacs: notmuch-start-notmuch-error-sentinel: assert buffer is alive [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 06/32] emacs: notmuch-start-notmuch-sentinel: assert buffer is alive [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 07/32] emacs: notmuch-start-notmuch: avoid storing process buffer twice [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 08/32] emacs: avoid passing around some redundant information [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 09/32] emacs: avoid killing process buffer when process is still alive [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 10/32] emacs: make headings outline-minor-mode compatible [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 11/32] emacs: use lexical-bindings in all libraries [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 12/32] emacs: deal with unused lexical arguments and variables [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 13/32] emacs: notmuch-tag--get-formats: silence byte-compiler [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 14/32] emacs: inline notmuch-sexp-eof into only caller [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 15/32] emacs: notmuch-wash-region-to-button: remove unused MSG argument [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 16/32] emacs: silence compiler wrt notmuch-show-insert-part-text/plain [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 17/32] emacs: define notmuch-message-queued-tag-changes as buffer-local [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 18/32] emacs: notmuch-message-apply-queued-tag-changes: cosmetics [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 19/32] emacs: notmuch-wash.el: require diff-mode at beginning of code [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 20/32] emacs: notmuch-mua-prompt-for-sender: don't force Ido on users [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 21/32] emacs: notmuch-mua.el: move all options into "Options" section [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 22/32] emacs: notmuch-crypto-status-button-type: fix potential bug [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 23/32] emacs: various cosmetic improvements [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 24/32] emacs: various comment improvements [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 25/32] emacs: various doc-string improvements [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 26/32] emacs: remove variable notmuch-search-disjunctive-regexp [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 27/32] emacs: define a few variables as automatically buffer-local [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 28/32] emacs: notmuch-search-stash-thread-id: use notmuch-search-query-string [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 29/32] emacs: reorder notmuch.el a bit [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 30/32] emacs: avoid unnecessary let-bindings [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 31/32] emacs: use string-empty-p [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 32/32] emacs: notmuch-tree-get-match: No longer define as command [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Tomi Ollila—Re: [PATCH 00/32] [emacs] Add outline headings and switch to lexical scope [inbox, unread]
    • Tomi Ollila—Re: [PATCH 00/32] [emacs] Add outline headings and switch to lexical scope [inbox, unread]
    • Jonas Bernoulli—Re: [PATCH 00/32] [emacs] Add outline headings and switch to lexical scope [inbox, unread]
  • Jonas Bernoulli—[PATCH v2 00/36] [emacs] Add outline headings and switch to lexical scope [inbox, unread]
    • Jonas Bernoulli—[PATCH v2 01/36] emacs: use setq instead of set [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 02/36] emacs: sanitize dedicated widget action/notify functions [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 03/36] emacs: define new notmuch-search-item widget type [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 04/36] emacs: notmuch-start-notmuch: remove backward compatibility code [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 05/36] emacs: notmuch-start-notmuch-error-sentinel: assert buffer is alive [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 06/36] emacs: notmuch-start-notmuch-sentinel: assert buffer is alive [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 07/36] emacs: notmuch-start-notmuch: avoid storing process buffer twice [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 08/36] emacs: avoid passing around some redundant information [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 09/36] emacs: avoid killing process buffer when process is still alive [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 10/36] emacs: make headings outline-minor-mode compatible [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 11/36] emacs: use lexical-bindings in all libraries [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 12/36] emacs: deal with unused lexical arguments and variables [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 13/36] emacs: notmuch-tag--get-formats: silence byte-compiler [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 14/36] emacs: inline notmuch-sexp-eof into only caller [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 15/36] emacs: notmuch-wash-region-to-button: remove unused MSG argument [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 16/36] emacs: silence compiler wrt notmuch-show-insert-part-text/plain [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 17/36] emacs: define notmuch-message-queued-tag-changes as buffer-local [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 18/36] emacs: notmuch-message-apply-queued-tag-changes: cosmetics [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 19/36] emacs: notmuch-wash.el: require diff-mode at beginning of code [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 20/36] emacs: notmuch-mua-prompt-for-sender: don't force Ido on users [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 21/36] emacs: notmuch-mua.el: move all options into "Options" section [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 22/36] emacs: notmuch-crypto-status-button-type: fix potential bug [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 23/36] emacs: various cosmetic improvements [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Jonas Bernoulli—[PATCH v3 23/36] emacs: various cosmetic improvements [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 24/36] emacs: various comment improvements [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 25/36] emacs: various doc-string improvements [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 26/36] emacs: remove variable notmuch-search-disjunctive-regexp [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 27/36] emacs: define a few variables as automatically buffer-local [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 28/36] emacs: notmuch-search-stash-thread-id: use notmuch-search-query-string [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 29/36] emacs: reorder notmuch.el a bit [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 30/36] emacs: avoid unnecessary let-bindings [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 31/36] emacs: improve how cl-lib and pcase are required [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 32/36] emacs: make subr-x available in all libraries [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 33/36] emacs: use string-empty-p [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 34/36] emacs: notmuch-tree-get-match: No longer define as command [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 35/36] emacs: allow opting out of notmuch's address completion [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v2 36/36] emacs: notmuch-address-expand-name: use the actual initial-input [inbox, notmuch::patch, notmuch::pushed, unread]
      • David Bremner—Re: [PATCH v2 36/36] emacs: notmuch-address-expand-name: use the actual initial-input [inbox, unread]
    • Tomi Ollila—Re: [PATCH v2 00/36] [emacs] Add outline headings and switch to lexical scope [inbox, unread]
    • David Bremner—Re: [PATCH v2 00/36] [emacs] Add outline headings and switch to lexical scope [inbox, unread]
      • Tomi Ollila—Re: [PATCH v2 00/36] [emacs] Add outline headings and switch to lexical scope [inbox, unread]
      • Jonas Bernoulli—Re: [PATCH v2 00/36] [emacs] Add outline headings and switch to lexical scope [inbox, unread]