Hello,
This patch serious changes a number of things, including boring
cleanup, but the big changes are the following. The respective
commits are also marked in the list below. See these commits
for longer descriptions.
1. Split all libraries into sections by adding new headings or
formatting existing headings properly to be compatible with
outline-minor-mode.
2. Use lexical-scope in all libraries. This is potentially faster
and is recommended for all new code (and old code someone cares
about enough). It also has the advantage that it can reveal
subtle bugs.
Among the many more commits that do not concern these two big
changes, there are a few that might need special attention.
(Again see the commits for details.)
3. No longer use Ido in notmuch-mua-prompt-for-sender. Might be
controversial.
4. Stop using unnecessary let-bindings, though how "unnecessary"
these bindings are is somewhat subjective.
Cheers,
Jonas
PS: Don't worry. I do NOT have another large patch series waiting
after this. Future changes should be more focused or even come
in the form of independent extensions.
Jonas Bernoulli (32):
emacs: use setq instead of set
emacs: sanitize dedicated widget action/notify functions
emacs: define new notmuch-search-item widget type
emacs: notmuch-start-notmuch: remove backward compatibility code
emacs: notmuch-start-notmuch-error-sentinel: assert buffer is alive
emacs: notmuch-start-notmuch-sentinel: assert buffer is alive
emacs: notmuch-start-notmuch: avoid storing process buffer twice
emacs: avoid passing around some redundant information
emacs: avoid killing process buffer when process is still alive
1 emacs: make headings outline-minor-mode compatible
2 emacs: use lexical-bindings in all libraries
" emacs: deal with unused lexical arguments and variables
" emacs: notmuch-tag--get-formats: silence byte-compiler
emacs: inline notmuch-sexp-eof into only caller
emacs: notmuch-wash-region-to-button: remove unused MSG argument
emacs: silence compiler wrt notmuch-show-insert-part-text/plain
emacs: define notmuch-message-queued-tag-changes as buffer-local
emacs: notmuch-message-apply-queued-tag-changes: cosmetics
emacs: notmuch-wash.el: require diff-mode at beginning of code
3 emacs: notmuch-mua-prompt-for-sender: don't force Ido on users
emacs: notmuch-mua.el: move all options into "Options" section
emacs: notmuch-crypto-status-button-type: fix potential bug
emacs: various cosmetic improvements
emacs: various comment improvements
emacs: various doc-string improvements
emacs: remove variable notmuch-search-disjunctive-regexp
emacs: define a few variables as automatically buffer-local
emacs: notmuch-search-stash-thread-id: use notmuch-search-query-string
emacs: reorder notmuch.el a bit
4 emacs: avoid unnecessary let-bindings
emacs: use string-empty-p
emacs: notmuch-tree-get-match: No longer define as command
emacs/coolj.el | 14 +-
emacs/make-deps.el | 2 +-
emacs/notmuch-address.el | 65 +++++----
emacs/notmuch-company.el | 1 -
emacs/notmuch-compat.el | 4 +-
emacs/notmuch-crypto.el | 14 +-
emacs/notmuch-draft.el | 23 +++-
emacs/notmuch-hello.el | 228 +++++++++++++++---------------
emacs/notmuch-jump.el | 14 +-
emacs/notmuch-lib.el | 198 +++++++++++++-------------
emacs/notmuch-maildir-fcc.el | 112 +++++++--------
emacs/notmuch-message.el | 21 ++-
emacs/notmuch-mua.el | 123 +++++++++--------
emacs/notmuch-parser.el | 18 +--
emacs/notmuch-print.el | 16 ++-
emacs/notmuch-query.el | 21 ++-
emacs/notmuch-show.el | 127 ++++++++++-------
emacs/notmuch-tag.el | 100 ++++++++------
emacs/notmuch-tree.el | 59 ++++----
emacs/notmuch-wash.el | 54 ++++----
emacs/notmuch.el | 260 +++++++++++++++++++----------------
emacs/rstdoc.el | 2 +-
test/test-lib.el | 4 +-
23 files changed, 786 insertions(+), 694 deletions(-)
--
2.29.1
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org