Re: [PATCH 00/32] [emacs] Add outline headings and switch to lexical scope

Subject: Re: [PATCH 00/32] [emacs] Add outline headings and switch to lexical scope

Date: Wed, 30 Dec 2020 18:10:23 +0100

To: Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: Jonas Bernoulli


Tomi Ollila <tomi.ollila@iki.fi> writes:

> The patch series did not apply for me (fully) anymore.

Since you got it applied now I am not sending a second iteration just
yet, or should I?

By the way, a regularly rebased version can be found in the "pending"
branch at https://github.com/tarsiiformes/notmuch.git.  Currently it
ends with two additional commits that are not from this patch series but
which I have submitted separately (their commit messages are prefixed
with "[copy]").

> I like the series (on paper), 2 comments

:D

> In patch 23/32, line

Fixed

> Then, I personally don't see enough point for requiring subr-x
> just just for changing (string= foo "") to (string-empty-p). If
> there were more features picked from subr-x then that would be
> different...

I was on the fence about that too.  I left it in for now but have
no problems removing it before merge.

     Thanks for taking a look,
     Jonas
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: